fix(schemaorg): Enumeration type detection improved #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stiivo
changed the title
alanpoulain
reviewed
Jan 3, 2023
alanpoulain
reviewed
Jan 3, 2023
alanpoulain
reviewed
Jan 3, 2023
alanpoulain
reviewed
Jan 3, 2023
|
Thanks for the PR 🙂 You would want to add some tests too (E2E and/or unit). |
…ing if one of the parent elements is of type schema.org/Enumeration
Co-authored-by: Alan Poulain <contact@alanpoulain.eu>
Co-authored-by: Alan Poulain <contact@alanpoulain.eu>
Co-authored-by: Alan Poulain <contact@alanpoulain.eu>
dunglas
force-pushed
the
schema_org_enumeration_fix
branch
from
13fa851
to
3608979
Compare
|
Thanks @stiivo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enumeration type detection improved by traversing the graph and checking if one of the parent elements is of type schema.org/Enumeration