Drop support for Node.js < 4 #11
Conversation
| - 4 | ||
| - 6 | ||
| - 8 | ||
| - 'stable' |
There was a problem hiding this comment.
Ha! This is good. We could be using it also with the Dredd repo.
package.json
Outdated
| "chai": "1.7.1" | ||
| "chai": "^4.1.2", | ||
| "coffeescript": "^1.12.7", | ||
| "mocha": "^4.0.1" |
There was a problem hiding this comment.
There's a new process with us which requires us to use only approved dependencies. That basically means the deps' licensing needs to be all right. For this reason we're not relaxing the versions anymore.
To be honest, I wasn't much fan of the relaxed versions anyway. To me as a maintainer, they bring more hassle than benefit and it felt to me it's always better to just explicitly upgrade the deps, e.g. with the help of https://greenkeeper.io/
Would you please keep the versions pinned?
|
Updated with pinned versions. Sorry it took so long. Setting up GreenKeeper sounds like a good idea with this new constraint. |
package.json
Outdated
| "chai": "1.7.1" | ||
| "chai": "4.1.2", | ||
| "coffeescript": "1.12.7", | ||
| "mocha": "5.0.0" |
There was a problem hiding this comment.
I'm sorry this takes so long. We need to get this kumavis/browser-stdout#4 resolved first. Current Mocha has a license issue - their dependency tree contains the browser-stdout library, which has invalid license. I'll get back to this as soon as possible.
There was a problem hiding this comment.
Filed mochajs/mocha#3248
There was a problem hiding this comment.
Ah, that's a bummer. Looks like that dependency was added this commit which was first part of version 3.0.
Would it help if I used mocha 2.5.3 instead? That's the last release before this dependency was added.
There was a problem hiding this comment.
There is some activity on the Mocha issue, so let's see how it turns out. I'd better upgrade than downgrade, if possible. The same problem hurts Dredd, etc.
There was a problem hiding this comment.
browser-stdout 1.3.1 was released - now with a license file 🎉
Also updates dev dependencies to their latest version.