Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix markdown to disable an unnecessary link #896

Closed
wants to merge 3 commits into from

Conversation

honzajavorek
Copy link
Collaborator

I suppose this shouldn't be a real link.

Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be an inline code block too i guess

@B4nan B4nan changed the title Fix markdown to disable an unnecessary link docs: fix markdown to disable an unnecessary link Mar 26, 2024
@TC-MO
Copy link
Contributor

TC-MO commented Mar 28, 2024

I'll wait with merging this until the #897 us merged, as it fixes ~150 vale issues in academy and possibly these as well.

@TC-MO
Copy link
Contributor

TC-MO commented Mar 29, 2024

@B4nan could you take a look at these failing checks? Both of them are failing due to SmartLook but I thought that issue was already resolved on master?

@honzajavorek
Copy link
Collaborator Author

I made another PR, but the checks are failing with the same error: #907

B4nan added a commit that referenced this pull request Apr 5, 2024
Supersedes #896:

- better commit names
- made on top of current `master`, properly using `git` and not a GitHub
pencil 😅
- using inline code per @B4nan's comment
#896 (review)

---------

Co-authored-by: Martin Adámek <banan23@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants