fix: cheerio issues with HTML serialization #1113
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After update to
cheerio@1.0.0-rc.10
the$.html()
calls started failing with the following error:It's caused by some incompatibility between
htmlparser2
which is the streaming parser we use and which was originally used bycheerio
andparse5
, which is the new parser they use. We can easily override the parser, but not the serializer. It has some sort of compatibility layer, but it seems to be broken and the maintainer of parse5 says he doesn't have time to maintain the library. So let's use this hack to keep usinghtmlparser2
for serialization too.