fix(core): conversion between tough cookies and browser pool cookies #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit specifically fixes the conversion from tough cookies to browser pool cookies and vice versa, by correctly handling cookies where the domain has a leading dot versus when it doesn't.
silva95gustavo
force-pushed
the
fix-convert-tough-cookie-browser-pool-cookie
branch
from
8d8794e
to
2f19494
Compare
barjin
approved these changes
May 15, 2024
| expect(session.getCookieString('https://example.com')).toBe('cookie2=your-cookie'); | ||
| }); | ||
|
|
||
| test('getCookies should work', () => { |
There was a problem hiding this comment.
Can we maybe rename this test to something more fitting?
Suggested change
| test('getCookies should work', () => { | |
| test('getCookies transforms hostOnly domains correctly', () => { |
There was a problem hiding this comment.
@barjin this test is actually not testing hostOnly domains, instead it uses a domain that does not have this property enabled. The hostOnly-specific test comes right after. What do you say?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the conversion from tough cookies to browser pool cookies and vice versa, by correctly handling cookies where the domain has a leading dot versus when it doesn't.