Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EntityQuery: Add support for filtering by attribute value #950

Open
wants to merge 6 commits into
base: 3.x
Choose a base branch
from
Open

EntityQuery: Add support for filtering by attribute value #950

wants to merge 6 commits into from

Conversation

mxr576
Copy link
Contributor

@mxr576 mxr576 commented Oct 5, 2023 •
edited

shishir-intelli
shishir-intelli approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shishir-intelli shishir-intelli added the help wanted Extra attention is needed label Oct 13, 2023
@boobaa
Copy link
Contributor

boobaa commented Mar 25, 2024

Original version of this PR works great for filtering on attribute names that does NOT contain any underscores. If an attribute contains underscores (eg. foo_bar), then the original version was looking for a "normalized" attribute name (eg. fooBar).

The updated version allows underscores in attribute names, by NOT normalizing the attribute name if the Condition's $property starts with AttributeValue..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shishir-intelli shishir-intelli shishir-intelli approved these changes

Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Entity query: support filtering by attribute value
3 participants
@mxr576 @boobaa @shishir-intelli