-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only inject hook.js
script for Firefox. Use ExecutionWorld.MAIN for Chrome
#1232
Conversation
This looks good to me (tested locally in Chrome and Firefox), but I'm slightly concerned: didn't you see the extension break with the current Firefox code, in Firefox? Could you reproduce that? |
Talked in our 1:1. Posting the answer here for transparency: I feel a bit more confident now in this change for a couple reasons:
|
We are going to wait to merge this for a few days after 4.7.0 goes out to ensure we catch any bugs or new issues that arise from that release. |
Putting in draft for now to avoid accidental merge until we are ready. |
So far we've seen no reports that the latest update caused any more issues. I'll go ahead and merge this and get a release out tomorrow. |
Fixes #1162
This is a revival of #1164 with some tweaks. Now that we are running Chrome on Manifest v3, we are able to use
hook.js
as a content script usingExecutionWorld.MAIN
. Unfortunately this is not yet supported in Firefox, so we have to rely on script injection for this to work. The script injection used in #1164 is now added back, but only when building for Firefox.