apply documentTransforms before rerunning simulated queries #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/release:pr |
size-limit report 📦
|
Job #75: Bundle Size — 1.01MiB (~+0.01%).Warning Bundle contains 1 duplicate package – View duplicate packages Bundle metrics
 
Bundle size by type
View job #75 report View pr/fix-simulatedQueries branch activity View project dashboard |
|
A new release has been made for this PR. You can install the package you need using one of
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this would fix #256
While the
__typenametransform normally is applied in both queries happening during SSR, and in the Browser, in the case where a query could not fully be transported from SSR to the Browser (e.g. in the case an error was thrown on the server, or because the stream closed before it was fully transported over), these would be replayed as "simulated queries", and in that case the transform was not applied.Hint for review: hide whitespace :)