Supports "no-cache" fetchPolicy with pollInterval #10020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 19, 2022
benjamn
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
LGTM, with some non-blocking suggestions for possible simplifications. Thanks @MrDoomBringer!
Co-authored-by: Ben Newman <ben@benjamn.com>
…ger/apollo-client into pollinterval-no-cache
benasher44
reviewed
Aug 25, 2022
Co-authored-by: Ben Asher <benasher44@gmail.com>
|
@MrDoomBringer @hwillson 👋 is there anything preventing us from merging this change in now? |
hwillson
approved these changes
Sep 1, 2022
|
@jpvajda I'm 👍 with merging. Thanks! |
This was referenced Sep 2, 2022
viliket
added a commit
to viliket/live-trains-finland
that referenced
this pull request
Nov 19, 2022
- Update apollo client to latest version to fix bug where "no-cache" does not work when pollInterval is set - see apollographql/apollo-client#10020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9691
Fixes #6187
Adds support for the "no-cache" fetchPolicy to pollInterval.
Most fetchPolicies don't make sense to use when polling, as users probably don't want to be polling the cache directly. As such, currently polling will overwrite the fetchPolicy with "network-only".
However, "no-cache" is also useful for when the user wants to control whether or not their results are written to the cache, so this PR goes ahead and adds a check to allow that policy through, and a relevant test.
The check this adds looks similar to a fetchPolicy sieve in
refetch(), and it might be worth looking into how to make that functionality a bit more generalized/cleaner.I also went ahead and added a
pollFetchPolicytype as a way to codify and clarify the rationale for this change, please let me know if I should change anything here!Checklist: