change UseFragmentResult to union type
#10765
Conversation
🦋 Changeset detectedLatest commit: 930623f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -115,7 +121,7 @@ function diffToResult<TData>( | |||
| diff: Cache.DiffResult<TData>, | |||
| ): UseFragmentResult<TData> { | |||
| const result: UseFragmentResult<TData> = { | |||
| data: diff.result, | |||
| data: diff.result!, | |||
There was a problem hiding this comment.
From what I saw in the tests, this will never be undefined, but come out as {} - I adjusted the types accordingly.
@benjamn, can you please take a look here to make sure I didn't forget about some edge case?
| @@ -349,9 +350,10 @@ describe("useFragment", () => { | |||
| from: { __typename: "Query" }, | |||
| }); | |||
| expect(complete).toBe(true); | |||
| assert(!!complete) | |||
There was a problem hiding this comment.
the assert call is here so TypeScript knows that data is complete in the JSX.
src/react/hooks/useFragment.ts
Outdated
| missing?: MissingTree; | ||
| } | ||
| | { | ||
| data: Partial<TData>; |
There was a problem hiding this comment.
Should we use a DeepPartial here since you can give a fragment that could contain nested field selections?
There was a problem hiding this comment.
Good point. We don't have a DeepPartial type at this point yet though - and the one added with #10766 will land in 3.8. We should coordinate around that.
phryneas
force-pushed
the
useFragment-union-return-type
branch
from
f65bf2f
to
d4e3f0a
Compare
✅ Deploy Preview for apollo-client-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@jerelmiller this now uses |
This should be merged after #10764 and is the second half of suggestions from #10760 and would address #10650.
It also adds a test to make sure the types actually reflect the real behaviour.
Checklist: