Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage of WeakMap in React Native Hermes #10804

Merged
merged 8 commits into from Dec 8, 2023
Merged

Conversation

phryneas
Copy link
Member

I've stumbled over this canUseWeakMap check by accident. I believe that at least in the React Native Hermes engine, we should be fine using WeakMap.

I will still have to verify this though, so I'm just putting this up as a Draft PR to look into later.

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2023

🦋 Changeset detected

Latest commit: 69ffe10

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@phryneas
Copy link
Member Author

/release:pr

@github-actions
Copy link
Contributor

A new release has been made for this PR. You can install it with npm i @apollo/client@0.0.0-pr-10804-20230531080344.

@github-actions
Copy link
Contributor

github-actions bot commented May 31, 2023

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 37.68 KB (+0.04% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 44.22 KB (+0.03% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 42.69 KB (+0.03% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 32.92 KB (+0.04% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 31.61 KB (+0.05% 🔺)
import { ApolloProvider } from "dist/react/index.js" 1.24 KB (+1.04% 🔺)
import { ApolloProvider } from "dist/react/index.js" (production) 1.22 KB (+1.05% 🔺)
import { useQuery } from "dist/react/index.js" 4.34 KB (+0.28% 🔺)
import { useQuery } from "dist/react/index.js" (production) 4.16 KB (+0.24% 🔺)
import { useLazyQuery } from "dist/react/index.js" 4.65 KB (+0.26% 🔺)
import { useLazyQuery } from "dist/react/index.js" (production) 4.47 KB (+0.25% 🔺)
import { useMutation } from "dist/react/index.js" 2.62 KB (+0.46% 🔺)
import { useMutation } from "dist/react/index.js" (production) 2.6 KB (+0.57% 🔺)
import { useSubscription } from "dist/react/index.js" 2.3 KB (+0.6% 🔺)
import { useSubscription } from "dist/react/index.js" (production) 2.26 KB (+0.53% 🔺)
import { useSuspenseQuery } from "dist/react/index.js" 4.31 KB (+0.35% 🔺)
import { useSuspenseQuery } from "dist/react/index.js" (production) 3.72 KB (+0.37% 🔺)
import { useBackgroundQuery } from "dist/react/index.js" 3.89 KB (+0.31% 🔺)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.29 KB (+0.39% 🔺)
import { useLoadableQuery } from "dist/react/index.js" 4.13 KB (+0.34% 🔺)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.53 KB (+0.42% 🔺)
import { useReadQuery } from "dist/react/index.js" 3.02 KB (+0.39% 🔺)
import { useReadQuery } from "dist/react/index.js" (production) 2.96 KB (+0.34% 🔺)
import { useFragment } from "dist/react/index.js" 2.11 KB (+0.56% 🔺)
import { useFragment } from "dist/react/index.js" (production) 2.06 KB (+0.58% 🔺)

Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit d8fbe5b
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/6570a1f8faa1d30008a772c3
😎 Deploy Preview https://deploy-preview-10804--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@phryneas phryneas changed the base branch from main to release-3.9 December 7, 2023 16:26
@phryneas phryneas marked this pull request as ready for review December 7, 2023 16:28
@phryneas phryneas added the auto-cleanup 🤖 label Dec 8, 2023
@phryneas phryneas merged commit 221dd99 into release-3.9 Dec 8, 2023
22 checks passed
@phryneas phryneas deleted the pr/hermes-weakmap branch December 8, 2023 12:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants