Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react/internal entry point and update existing imports #11439

Merged
merged 11 commits into from Dec 19, 2023

Conversation

jerelmiller
Copy link
Member

This is a reimplementation of #11426 with the latest changes from release-3.9.

We had some bundling issues that caused some of the internals of the react/cache folder to be duplicated in the bundle. This was due to the fact that react/hooks is its own entry point, and the new createQueryPreloader function that was introduced also pulled in these dependencies outside the react/hooks folder.

Checklist:

  • If this PR contains changes to the library itself (not necessary for e.g. docs updates), please include a changeset (see CONTRIBUTING.md)
  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

Copy link

changeset-bot bot commented Dec 19, 2023

🦋 Changeset detected

Latest commit: 3acbf58

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 19, 2023

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.22 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 46.01 KB (-0.07% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 43.57 KB (-0.06% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 33.96 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 31.89 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.24 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.22 KB (0%)
import { useQuery } from "dist/react/index.js" 5.2 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.27 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.51 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.58 KB (0%)
import { useMutation } from "dist/react/index.js" 3.51 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.73 KB (0%)
import { useSubscription } from "dist/react/index.js" 3.19 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.39 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.28 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 3.94 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.76 KB (+0.03% 🔺)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.41 KB (+0.03% 🔺)
import { useLoadableQuery } from "dist/react/index.js" 4.98 KB (-0.04% 🔽)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.64 KB (+0.14% 🔺)
import { useReadQuery } from "dist/react/index.js" 3.03 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 2.97 KB (+0.04% 🔺)
import { useFragment } from "dist/react/index.js" 2.1 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.05 KB (0%)

@@ -1,4 +1,4 @@
{
"dist/apollo-client.min.cjs": 39137,
"import { ApolloClient, InMemoryCache, HttpLink } from \"dist/index.js\" (production)": 32653
"dist/apollo-client.min.cjs": 39184,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Putting the minified files next to each other, there is literally no difference in them apart from the version number - I think this might have been a tad off in the upstream branch or something.

Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 844b3df
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/658122fd91f086000805a33a
😎 Deploy Preview https://deploy-preview-11439--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jerelmiller
Copy link
Member Author

We are now getting the deduplication of the cache internals as expected: https://github.com/apollographql/apollo-client/actions/runs/7257554913

Copy link

netlify bot commented Dec 19, 2023

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 5bdb941
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/658123e979533200088a9e8d
😎 Deploy Preview https://deploy-preview-11439--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@phryneas
Copy link
Member

/release:pr

Copy link
Contributor

A new release has been made for this PR. You can install it with npm i @apollo/client@0.0.0-pr-11439-20231219100639.

Copy link
Member

@phryneas phryneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, let's get this in! 🚀

@github-actions github-actions bot added the auto-cleanup 🤖 label Dec 19, 2023
@jerelmiller jerelmiller merged commit 33454f0 into release-3.9 Dec 19, 2023
36 checks passed
@jerelmiller jerelmiller deleted the jerel/react-internal-entry branch December 19, 2023 14:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants