Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import to rehackt in useLazyRef #11552

Merged
merged 2 commits into from Feb 1, 2024
Merged

Conversation

jerelmiller
Copy link
Member

Fixes apollographql/apollo-client-nextjs#186

useLazyRef was introduced by #11464 and released in in 3.8.9, but the import had not been updated to rehackt before our 3.9 release causing some import issues in our experimental package.

@jerelmiller jerelmiller requested a review from a team as a code owner February 1, 2024 14:12
Copy link

changeset-bot bot commented Feb 1, 2024

🦋 Changeset detected

Latest commit: 8624c48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 1, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.13 KB (-0.03% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 45.95 KB (-0.05% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 43.49 KB (-0.05% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 33.88 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 31.8 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.23 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.21 KB (0%)
import { useQuery } from "dist/react/index.js" 5.2 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.27 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.5 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.58 KB (0%)
import { useMutation } from "dist/react/index.js" 3.51 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.73 KB (0%)
import { useSubscription } from "dist/react/index.js" 3.19 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.38 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.28 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 3.94 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.75 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.4 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 4.97 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.63 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.04 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 2.98 KB (0%)
import { useFragment } from "dist/react/index.js" 2.18 KB (-0.09% 🔽)
import { useFragment } from "dist/react/index.js" (production) 2.13 KB (-0.05% 🔽)

@jerelmiller
Copy link
Member Author

/release:pr

Copy link
Contributor

github-actions bot commented Feb 1, 2024

A new release has been made for this PR. You can install it with npm i @apollo/client@0.0.0-pr-11552-20240201141556.

Copy link
Member

@phryneas phryneas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, wow, shouldn't have eslint caught this?

Immediate approval!

@github-actions github-actions bot added the auto-cleanup 🤖 label Feb 1, 2024
@jerelmiller
Copy link
Member Author

@phryneas I thought the same thing!

@phryneas phryneas merged commit 6ac2b0c into main Feb 1, 2024
35 checks passed
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'useRef' is not exported from 'react'
2 participants