Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: caching issue in #11560 (reverts #11202) #11576

Merged
merged 4 commits into from Feb 6, 2024
Merged

fix: caching issue in #11560 (reverts #11202) #11576

merged 4 commits into from Feb 6, 2024

Conversation

alessbell
Copy link
Member

Reverts PR #11202 to fix caching bug reported in #11560. Closes #11560.

…ueryInfo-markResult-result.data-mutation"

This reverts commit 8b6e10b, reversing
changes made to 7c90f9a.
@alessbell alessbell requested a review from a team as a code owner February 6, 2024 20:40
Copy link

changeset-bot bot commented Feb 6, 2024

🦋 Changeset detected

Latest commit: e59d4be

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alessbell alessbell changed the title Issue 11560 fix: caching issue in #11560 (reverts #11202) Feb 6, 2024
Copy link
Contributor

github-actions bot commented Feb 6, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.13 KB (-0.03% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 45.94 KB (-0.02% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 43.48 KB (-0.03% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 33.86 KB (-0.07% 🔽)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 31.79 KB (-0.03% 🔽)
import { ApolloProvider } from "dist/react/index.js" 1.23 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.22 KB (0%)
import { useQuery } from "dist/react/index.js" 5.2 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.27 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.5 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.58 KB (0%)
import { useMutation } from "dist/react/index.js" 3.51 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.73 KB (0%)
import { useSubscription } from "dist/react/index.js" 3.19 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.38 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.28 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 3.94 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.75 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.4 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 4.97 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.63 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.04 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 2.98 KB (0%)
import { useFragment } from "dist/react/index.js" 2.18 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.13 KB (0%)

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in person and I think this is the right move. Hopefully we can revisit the original bug soon 🙂

@github-actions github-actions bot added the auto-cleanup 🤖 label Feb 6, 2024
Copy link

netlify bot commented Feb 6, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit cf11bb9
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/65c29950b3a50d000832d51b
😎 Deploy Preview https://deploy-preview-11576--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alessbell
Copy link
Member Author

/release:pr

Copy link
Contributor

github-actions bot commented Feb 6, 2024

A new release has been made for this PR. You can install it with npm i @apollo/client@0.0.0-pr-11576-20240206204955.

@alessbell alessbell merged commit e855d00 into main Feb 6, 2024
27 checks passed
@github-actions github-actions bot mentioned this pull request Feb 6, 2024
@alessbell alessbell deleted the issue-11560 branch February 6, 2024 22:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apollo Client has null values filtered in queries since v3.9.0 when using a type policy
2 participants