Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make useRenderGuard more resilient to changes in React internals. #11659

Merged
merged 2 commits into from Mar 11, 2024

Conversation

phryneas
Copy link
Member

@phryneas phryneas commented Mar 11, 2024

Since we don't know what exactly might be change with React 19, this change makes our useRenderGuard slightly more resilient, and if it breaks, it does so in a less interrupting way (always return false instead of always true).

It should also save one byte of bundle size ;) But then it gzips 2 bytes bigger 🤦

@phryneas phryneas requested a review from a team as a code owner March 11, 2024 14:15
Copy link
Contributor

github-actions bot commented Mar 11, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.33 KB (+0.01% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 46.15 KB (+0.01% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 43.72 KB (+0.01% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 33.95 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 31.87 KB (0%)
import { ApolloProvider } from "dist/react/index.js" 1.23 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.21 KB (0%)
import { useQuery } from "dist/react/index.js" 5.26 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.35 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.5 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.58 KB (0%)
import { useMutation } from "dist/react/index.js" 3.51 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.73 KB (0%)
import { useSubscription } from "dist/react/index.js" 3.19 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.38 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.37 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.03 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.83 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.49 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 4.98 KB (+0.02% 🔺)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.63 KB (+0.06% 🔺)
import { useReadQuery } from "dist/react/index.js" 3.12 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.06 KB (0%)
import { useFragment } from "dist/react/index.js" 2.25 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.2 KB (0%)

Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit 7234074
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/65ef121c72114a0008522534
😎 Deploy Preview https://deploy-preview-11659--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

changeset-bot bot commented Mar 11, 2024

🦋 Changeset detected

Latest commit: f042fff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that deleting a character resulted in a 2 byte increase 🤔. Thanks for putting this together though!

@github-actions github-actions bot added the auto-cleanup 🤖 label Mar 11, 2024
@phryneas phryneas merged commit 652a61e into main Mar 11, 2024
35 checks passed
@phryneas phryneas deleted the pr/resilient_useRenderGuard branch March 11, 2024 16:56
@github-actions github-actions bot mentioned this pull request Mar 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants