Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watchFragment fixes #11754

Merged
merged 7 commits into from Apr 4, 2024
Merged

watchFragment fixes #11754

merged 7 commits into from Apr 4, 2024

Conversation

alessbell
Copy link
Member

Glad I started implementing the integration with apollo-angular because I found some minor issues :)

Copy link

changeset-bot bot commented Apr 4, 2024

🦋 Changeset detected

Latest commit: b9477c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@apollo/client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alessbell
Copy link
Member Author

/release:pr

@alessbell alessbell requested a review from phryneas April 4, 2024 20:40
Copy link
Contributor

github-actions bot commented Apr 4, 2024

size-limit report 📦

Path Size
dist/apollo-client.min.cjs 38.59 KB (+0.03% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" 46.46 KB (+0.02% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production) 44.01 KB (+0.03% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" 34.16 KB (+0.03% 🔺)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production) 32.04 KB (+0.04% 🔺)
import { ApolloProvider } from "dist/react/index.js" 1.24 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production) 1.22 KB (0%)
import { useQuery } from "dist/react/index.js" 5.27 KB (0%)
import { useQuery } from "dist/react/index.js" (production) 4.35 KB (0%)
import { useLazyQuery } from "dist/react/index.js" 5.51 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production) 4.58 KB (0%)
import { useMutation } from "dist/react/index.js" 3.51 KB (0%)
import { useMutation } from "dist/react/index.js" (production) 2.73 KB (0%)
import { useSubscription } from "dist/react/index.js" 3.19 KB (0%)
import { useSubscription } from "dist/react/index.js" (production) 2.38 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" 5.45 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production) 4.11 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" 4.92 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production) 3.58 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" 5.03 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production) 3.69 KB (0%)
import { useReadQuery } from "dist/react/index.js" 3.17 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production) 3.11 KB (0%)
import { useFragment } from "dist/react/index.js" 2.29 KB (0%)
import { useFragment } from "dist/react/index.js" (production) 2.24 KB (0%)

Copy link
Contributor

github-actions bot commented Apr 4, 2024

A new release has been made for this PR. You can install it with:

npm i @apollo/client@0.0.0-pr-11754-20240404204051

Copy link

netlify bot commented Apr 4, 2024

Deploy Preview for apollo-client-docs ready!

Name Link
🔨 Latest commit b9477c5
🔍 Latest deploy log https://app.netlify.com/sites/apollo-client-docs/deploys/660f14700000bd00087186bf
😎 Deploy Preview https://deploy-preview-11754--apollo-client-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -239,6 +239,7 @@ export class ApolloClient<TCacheShape> implements DataProxy {
this.watchQuery = this.watchQuery.bind(this);
this.query = this.query.bind(this);
this.mutate = this.mutate.bind(this);
this.watchQuery = this.watchQuery.bind(this);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.watchQuery = this.watchQuery.bind(this);
this.watchFragment = this.watchFragment.bind(this);

Did you mean to write this? I think this was your intention based on the changelog 🙂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So weird! Yes, I definitely meant watchFragment there 🥲

Copy link
Member

@jerelmiller jerelmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you'll update the constructor as you see fit 🙂. Good catch!

@github-actions github-actions bot added the auto-cleanup 🤖 label Apr 4, 2024
@alessbell
Copy link
Member Author

/release:pr

Copy link
Contributor

github-actions bot commented Apr 4, 2024

A new release has been made for this PR. You can install it with:

npm i @apollo/client@0.0.0-pr-11754-20240404204940

@alessbell alessbell merged commit 80d2ba5 into release-3.10 Apr 4, 2024
27 checks passed
@alessbell alessbell deleted the watchFragment-fixes branch April 4, 2024 21:24
@github-actions github-actions bot mentioned this pull request Apr 4, 2024
@github-actions github-actions bot mentioned this pull request Apr 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants