feat: deep merge resolvers

[alessbell]

Closes #11758.

[changeset-bot]

🦋 Changeset detected

Latest commit: c6eaea4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@apollo/client	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/apollo-client.min.cjs	38.61 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs"	46.49 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/main.cjs" (production)	44.04 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js"	34.16 KB (0%)
import { ApolloClient, InMemoryCache, HttpLink } from "dist/index.js" (production)	32.04 KB (0%)
import { ApolloProvider } from "dist/react/index.js"	1.24 KB (0%)
import { ApolloProvider } from "dist/react/index.js" (production)	1.22 KB (0%)
import { useQuery } from "dist/react/index.js"	5.27 KB (0%)
import { useQuery } from "dist/react/index.js" (production)	4.35 KB (0%)
import { useLazyQuery } from "dist/react/index.js"	5.51 KB (0%)
import { useLazyQuery } from "dist/react/index.js" (production)	4.58 KB (0%)
import { useMutation } from "dist/react/index.js"	3.51 KB (0%)
import { useMutation } from "dist/react/index.js" (production)	2.73 KB (0%)
import { useSubscription } from "dist/react/index.js"	3.19 KB (0%)
import { useSubscription } from "dist/react/index.js" (production)	2.38 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js"	5.44 KB (0%)
import { useSuspenseQuery } from "dist/react/index.js" (production)	4.11 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js"	4.92 KB (0%)
import { useBackgroundQuery } from "dist/react/index.js" (production)	3.58 KB (0%)
import { useLoadableQuery } from "dist/react/index.js"	5.03 KB (0%)
import { useLoadableQuery } from "dist/react/index.js" (production)	3.69 KB (0%)
import { useReadQuery } from "dist/react/index.js"	3.32 KB (0%)
import { useReadQuery } from "dist/react/index.js" (production)	3.26 KB (0%)
import { useFragment } from "dist/react/index.js"	2.29 KB (0%)
import { useFragment } from "dist/react/index.js" (production)	2.24 KB (0%)

[netlify]

✅ Deploy Preview for apollo-client-docs ready!

Name	Link
🔨 Latest commit	5d6a069
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/66102c996552f70008f905bb
😎 Deploy Preview	https://deploy-preview-11760--apollo-client-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify]

✅ Deploy Preview for apollo-client-docs ready!

Name	Link
🔨 Latest commit	c6eaea4
🔍 Latest deploy log	https://app.netlify.com/sites/apollo-client-docs/deploys/661d94e93f687700096c7b55
😎 Deploy Preview	https://deploy-preview-11760--apollo-client-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[alessbell]

NB: src/link/persisted-queries/__tests__/persisted-queries.test.ts failed on CI but when I run it locally it passes. Smells like a CI flake so I'll try rerunning it.

[alessbell]

Very curious that this test is consistently failing on CI (not locally) given the changes in this PR... haven't had a chance to dig deeper here.

[jerelmiller]

Deep merging FTW! I love this!

I had a couple minor nits regarding the profiler, and one comment regarding the structure of the reset test, but otherwise looks good!

[jerelmiller]

While I totally understand why you setup these tests this way, I'm not super fond that these tests require a specific order in that this one needs to run before the other one to pass. Rather than separate it blocks, I'd advocate for combining them into a single bigger test that demonstrates that calling .add, then .reset will successfully reset back to the original resolvers.

I think all I'd add in the component setup for your tests is a <button > that calls refetch on the useSuspenseQuery that you can use to retrigger the network requests.

Thoughts?

[alessbell]

Updated in 0d49273

cc'ing @phryneas again here because the final test is failing with Exceeded timeout waiting for next render. I've brought over the profiler fix from the other PR, and haven't been able to debug this yet...

[jerelmiller]

🎉 awesome awesome stuff!