Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use __DEV__ internally instead of process.env.NODE_ENV. #8347

Merged
merged 4 commits into from
Jun 15, 2021
Merged

Use __DEV__ internally instead of process.env.NODE_ENV. #8347

merged 4 commits into from
Jun 15, 2021

Commits on Jun 15, 2021

  1. Experiment: use __DEV__ instead of process.env.NODE_ENV. 

    See PR #8347 for full explanation.
    @benjamn
    benjamn committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    44a1918 View commit details
    Browse the repository at this point in the history

  2. Temporarily polyfill global.process while importing graphql package. 

    As explained in #8347 (comment)

We can revert this commit when no supported version of the `graphql`
package still uses process.env.NODE_ENV.
    @benjamn
    benjamn committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    fcb2c7d View commit details
    Browse the repository at this point in the history

  3. Warn about usage of __DEV__ polyfill. 

    #8347 (comment)

In Node.js, process.env is a reliable global API, and bundle sizes are
less relevant than for browser applications, so it's not as helpful to
warn about __DEV__ minification when running in Node.js.
    @benjamn
    benjamn committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    8f68762 View commit details
    Browse the repository at this point in the history

  4. Increase bundlesize limit from 24.5kB to 24.7kB.

    @benjamn
    benjamn committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    56b1cb5 View commit details
    Browse the repository at this point in the history