Release 3.5.0 #8554
Merged
Release 3.5.0 #8554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider trying to load `@apollo/client/core` in node.js
```bash
node -v # 16.3.0
```
```js
// server/index.js
import { ApolloClient } from '@apollo/client/core';
```
> import { ApolloClient, InMemoryCache } from '@apollo/client/core/index.js';
> ^^^^^^^^^^^^
> SyntaxError: Named export 'ApolloClient' not found. The requested module '@apollo/client/core/index.js' is a CommonJS module, which may not support all module.exports as named exports.
> CommonJS modules can always be imported via the default export, for example using:
```js
import AC from '@apollo/client/core';
const { ApolloClient } = AC;
```
> (node:35704) Warning: To load an ES module, set "type": "module" in the package.json or use the .mjs extension.
> (Use `node --trace-warnings ...` to show where the warning was created)
> /path/to/node_modules/@apollo/client/core/index.js:1
> export { ApolloClient, mergeOptions, } from "./ApolloClient.js";
> ^^^^^^
>
> SyntaxError: Unexpected token 'export'
adding `"type": "module"` to core will solve those errors nicely
For example, this rewrites the import from "ts-invariant/process" in @apollo/client/utilities/globals/graphql.js to instead import from "ts-invariant/process/index.js, so Node.js won't complain about the directory import (even though ts-invariant/process/package.json exists).
Add `"type": "module"` to `@apollo/client/**/package.json` (all entry points).
This will allow us to release the changes from PR #8558 in a beta release before merging them to main and publishing v3.4.1.
The root package.json file was neglected in #8396, since it isn't generated in the same way as the other (nested) package.json files. This commit puts `"type": "module"` in the _published_ `@apollo/client/package.json` file, which is generated at build time as the file `dist/package.json`. The root `package.json` file that's checked into the repository does _not_ contain `"type": "module"` (even though putting it there would also put it in `dist/package.json`). Attempting to enable ES module syntax at that level interfered pretty severely with tools like ts-node, which we use to run various config/*.ts scripts. Rewriting those scripts is a job for another time. I'm happy to revisit this as the ecosystem progresses.
…using-StoreObject-in-processSelectionSet Identify written results using processed `StoreObject` in `StoreWriter#processSelectionSet`
…to-v27 Update Jest-related dependencies to latest version (v27) to address `npm audit` problems
Our docs `typedoc` version has fallen behind and has recently started throwing `Maximum call stack size exceeded` errors when trying to generate types via `npm run types`. This was likely caused by a recent `typescript` update (e.g. #8926), but regardless updating to a current version of `typedoc` fixes the issue. Note that the `typedoc` `--ignoreCompilerErrors` option was removed in version 0.20, so this commit also removes it from the docs scripts.
brainkim
approved these changes
Nov 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the Release 3.4.0 PR, this PR will serve to collect significant new features, deprecation warnings, and minor breaking changes that we intend to release in
@apollo/client@3.5.0.If you want to test these changes, run
in your application, where the
nin-beta.ncomes from the most recent commit message likeUntil v3.5.0 is released, we can continue merging smaller changes into
mainand releasing them, without worrying about larger changes on therelease-3.5branch.