Pin CircleCI container to cimg/node:16.8 until 16.9.1 available
#8800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug nodejs/node#40030 will be fixed in Node.js v16.9.1: https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V16.md#2021-09-10-version-1691-current-richardlau This bug has been causing frequent spurious test failures for Apollo Client. A few examples: https://app.circleci.com/pipelines/github/apollographql/apollo-client/11547/workflows/4027b7e7-b8bd-4cf1-8927-f08921a4c577/jobs/83124 https://app.circleci.com/pipelines/github/apollographql/apollo-client/11571/workflows/3e78ba11-0e51-4f4f-92dd-e732c53716d2/jobs/83167 https://app.circleci.com/pipelines/github/apollographql/apollo-client/11536/workflows/55d29d9f-b4a7-4803-80bb-e3891946960d/jobs/83106 CircleCI ships docker containers for most Node.js versions, but they haven't shipped a new version for 16.9.1 yet (16.9.0 is the latest). We will switch back to `cimg/node:16` once that gives us a version greater than or equal to 16.9.1.
benjamn
commented
Sep 16, 2021
| - image: circleci/node:16 | ||
| - image: cimg/node:16.8 |
There was a problem hiding this comment.
I switched to cimg/node because I saw this line in its README.md:
This image is designed to supercede the legacy CircleCI Node.js image, circleci/node.
|
Since the CircleCI tests are passing for this PR, I'm going to go ahead and merge it so no one else is confused by these test failures. |
benjamn
added a commit
that referenced
this pull request
Sep 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream Node.js bug nodejs/node#40030 has been fixed in Node.js v16.9.1. This bug has recently been causing frequent spurious test failures for Apollo Client. A few examples.
Failure message, for posterity:
CircleCI ships docker containers for most Node.js versions, but they haven't shipped a new version for 16.9.1 yet (16.9.0 is the latest). We will switch back to
cimg/node:16once that gives us a version greater than or equal to 16.9.1.