Field Merging[1/x] Configuration Options #306
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eclectic-pie-88a2ba canceled.
|
✅ Deploy Preview for apollo-ios-docc canceled.
|
AnthonyMDev
force-pushed
the
03-20-field_merging_1_x_configuration_options
branch
from
1353191
to
eec8762
Compare
AnthonyMDev
changed the base branch from
main
to
Remove_redundant_iteration_in_EntitySelectionTree_merging_algorithm
AnthonyMDev
force-pushed
the
03-20-field_merging_1_x_configuration_options
branch
from
eec8762
to
f9cdce4
Compare
Base automatically changed from
Remove_redundant_iteration_in_EntitySelectionTree_merging_algorithm
to
main
March 22, 2024 18:10
AnthonyMDev
force-pushed
the
03-20-field_merging_1_x_configuration_options
branch
from
f9cdce4
to
88084be
Compare
AnthonyMDev
force-pushed
the
03-20-field_merging_1_x_configuration_options
branch
from
88084be
to
5748c50
Compare
…tringly typed Codable usage for JSON encoding
AnthonyMDev
force-pushed
the
03-20-field_merging_1_x_configuration_options
branch
from
5748c50
to
86fec35
Compare
| @@ -1351,6 +1483,7 @@ extension ApolloCodegenConfiguration.OutputOptions { | |||
| deprecatedEnumCases: ApolloCodegenConfiguration.Composition = Default.deprecatedEnumCases, | |||
| schemaDocumentation: ApolloCodegenConfiguration.Composition = Default.schemaDocumentation, | |||
| selectionSetInitializers: ApolloCodegenConfiguration.SelectionSetInitializers = Default.selectionSetInitializers, | |||
| fieldMerging: ApolloCodegenConfiguration.FieldMerging = Default.fieldMerging, | |||
There was a problem hiding this comment.
What's the reason for adding this parameter to the initializer parameters? Couldn't we just be using Default.fieldMerging down in the body of the initializer? That would maintain the signature and functionality both as before and if a user wants the new functionality then they must use the new initializer?
| @@ -169,6 +169,7 @@ extension ComputedSelectionSet { | |||
| fileprivate func finalize() -> ComputedSelectionSet { | |||
| let merged = MergedSelections( | |||
| mergedSources: mergedSources, | |||
| mergingStrategy: .all, | |||
There was a problem hiding this comment.
Does this change in a future PR to use the codegen configuration value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Update the configuration in ApolloCodegen to allow for selecting specific field merging strategies.
What changed?
Added the ability to select specific field merging strategies such as ancestors, siblings, and named fragments in the ApolloCodegen configuration.
How to test?
Unit tests have been added to ensure encoding and decoding of field merging configurations work correctly.
Why make this change?
This change provides more flexibility in handling merged fields and named fragment accessors in the generated selection set models.