Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically escape type in enum values #4295

Merged
merged 3 commits into from Jul 28, 2022
Merged

Conversation

martinbonnin
Copy link
Contributor

Since we can detect, we might as well to it on behalf of the user, this saves some configuration. See #4293

Note that if someone has already done something like this:

extend enum SomeEnum {
  type @targetName(name: "type_")
}

they will have to remove this to keep type_ or else it'll be renamed to type__.

Also remove a workaround we had for 'header' and 'impl' that was adressed in KotlinPoet with square/kotlinpoet#1248

@netlify
Copy link

netlify bot commented Jul 27, 2022

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 9f1ec5c
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/62e120ae33da7f00082c1421

Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit 33e0e01 into main Jul 28, 2022
@martinbonnin martinbonnin deleted the automatic-type-detection branch July 28, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants