Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow explicit CCN syntax #5148

Merged
merged 5 commits into from
Aug 3, 2023
Merged

Allow explicit CCN syntax #5148

merged 5 commits into from
Aug 3, 2023

Conversation

martinbonnin
Copy link
Contributor

Sync with graphql/graphql-spec#895 (comment)

Now all of these are allowed (and equivalent):

  list
  list[]

  list!
  list[]!

  matrix[!]
  matrix[[]!]

@martinbonnin martinbonnin requested a review from BoD as a code owner August 3, 2023 10:33
@netlify
Copy link

netlify bot commented Aug 3, 2023 •
edited

✅ Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 84ebe5a
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/64cbb7a6a37ae4000956e9c3

BoD
BoD approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin requested a review from BoD August 3, 2023 16:51
BoD
BoD approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin merged commit fb6245f into main Aug 3, 2023
10 checks passed
@martinbonnin martinbonnin deleted the match-spec branch August 3, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoD BoD BoD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@martinbonnin @BoD