adding checks for json end_document in http transport #5895
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@duzinkie: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
👷 Deploy request for apollo-android-docs pending review.Visit the deploys page to approve it
|
duzinkie
changed the title
Comment on lines
+48
to
+50
| if (jsonReader.peek() != JsonReader.Token.END_DOCUMENT) { | ||
| println("Apollo: extra tokens after payload") | ||
| } |
There was a problem hiding this comment.
2 things:
- Can you move this to the
toApolloResponse()function? I'd like to keep the possibility to read a single JSON object fromResponseParser.parsein the future - Let's make it an error? For this you can
throw JsonDataException("Expected END_DOCUMENT but was ${peek()}")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the issue is discussed in: #5885
this is the recommended fix for the no http batching scenario, for the main branch