Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closes #167 #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robbywashere-zz
Copy link

No description provided.

@apollo-cla
Copy link

@robbywashere: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@codecov-io
Copy link

codecov-io commented Oct 27, 2018

Codecov Report

Merging #168 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #168   +/-   ##
=======================================
  Coverage   92.65%   92.65%           
=======================================
  Files           2        2           
  Lines         395      395           
  Branches      117      117           
=======================================
  Hits          366      366           
  Misses         27       27           
  Partials        2        2
Impacted Files Coverage Δ
src/restLink.ts 92.44% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 461b4a3...c48dbc4. Read the comment docs.

@robbywashere-zz
Copy link
Author

robbywashere-zz commented Oct 27, 2018

This allows for another key value named constants on the context object which then may be used in the rest query path as context.constants.<key>

@fbartho fbartho self-requested a review November 5, 2019 18:33
Copy link
Collaborator

@fbartho fbartho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @robbywashere -- if you still want this, I'm inclined to merge it, but we need to add docs about it!

Docs, Comments, & Changelog would be great if you have time. Thoughts?

@dlferro
Copy link

dlferro commented Dec 1, 2020

Any updates to this? In terms of documentation, would this simply require updating the example from context.language to context.constants.language?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants