Skip to content

Commit

Permalink
Fix apolo-server-micro top level error response (#1619)
Browse files Browse the repository at this point in the history
Fixes #1581.
  • Loading branch information
fromthemills authored and martijnwalraven committed Sep 5, 2018
1 parent 88417b7 commit 4ab7bb3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Expand Up @@ -7,6 +7,7 @@ All of the packages in the `apollo-server` repo are released with the same versi
- Update `graphql-playground-html` to 1.7.4 [#1586](https://github.com/apollographql/apollo-server/pull/1586)
- Add support for `graphql-js` v14 by augmenting typeDefs with the `@cacheControl` directive so SDL validation doesn't fail [#1595](https://github.com/apollographql/apollo-server/pull/1595)
- Add `node-fetch` extensions typing to `RequestInit` [#1602](https://github.com/apollographql/apollo-server/pull/1602)
- Fix [#1581](https://github.com/apollographql/apollo-server/issues/1581) `apollo-server-micro` top level error response [#1619](https://github.com/apollographql/apollo-server/pull/1619)
- Switch `ApolloServerBase.schema` from private access to protected access. [#1610](https://github.com/apollographql/apollo-server/pull/1610)
- Add toggle for including error messages in reports [#1615](https://github.com/apollographql/apollo-server/pull/1615)
- Fix `apollo-server-cloud-functions` tests [#1611](https://github.com/apollographql/apollo-server/pull/1611/)
Expand Down
4 changes: 2 additions & 2 deletions packages/apollo-server-micro/src/microApollo.ts
Expand Up @@ -3,7 +3,7 @@ import {
runHttpQuery,
convertNodeHttpToRequest,
} from 'apollo-server-core';
import { json, RequestHandler } from 'micro';
import { send, json, RequestHandler } from 'micro';
import * as url from 'url';
import { IncomingMessage, ServerResponse } from 'http';

Expand Down Expand Up @@ -66,7 +66,7 @@ export function graphqlMicro(
error.statusCode = 500;
}

throw error;
send(res, error.statusCode, error.message);
}
};

Expand Down

0 comments on commit 4ab7bb3

Please sign in to comment.