fix(typing): type ContextFunction params separately from resulting co…

…ntext object
apollographql · Feb 21, 2019 · d08569e · d08569e
1 parent d05212e
commit d08569e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/apollo-server-core/src/types.ts b/packages/apollo-server-core/src/types.ts
@@ -29,10 +29,10 @@ export { GraphQLSchemaModule };
 
 export { KeyValueCache } from 'apollo-server-caching';
 
-export type ContextFunction<T = any> = (
-  context: Context<T>,
-) => Context<T> | Promise<Context<T>>;
 export type Context<T = object> = T;
+export type ContextFunction<FunctionParams = any, ContextContent = object> = (
+  context: FunctionParams,
+) => Context<ContextContent> | Promise<Context<ContextContent>>;
 
 // A plugin can return an interface that matches `ApolloServerPlugin`, or a
 // factory function that returns `ApolloServerPlugin`.

diff --git a/packages/apollo-server-express/src/ApolloServer.ts b/packages/apollo-server-express/src/ApolloServer.ts
@@ -77,7 +77,7 @@ interface ExpressContext {
 
 export interface ApolloServerExpressConfig extends Config {
   cors?: CorsOptions | boolean;
-  context?: ContextFunction<ExpressContext> | Context<ExpressContext>;
+  context?: ContextFunction<ExpressContext, Context> | Context;
 }
 
 export class ApolloServer extends ApolloServerBase {