Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL Playground settings do not get set #1746

Closed
omgrief opened this issue Sep 29, 2018 · 6 comments · Fixed by #1855
Closed

GraphQL Playground settings do not get set #1746

omgrief opened this issue Sep 29, 2018 · 6 comments · Fixed by #1855
Labels
🌹 has-reproduction ❤ Has a reproduction in Glitch, CodeSandbox or Git repository.

Comments

@omgrief
Copy link

omgrief commented Sep 29, 2018

const server = new ApolloServer({
  playground: {
    settings: {
      'request.credentials': 'include',
    }
  },
  ...otherServerSettings
);

Go to your GraphQL Playground route, and notice that the settings are just default settings.

related to github.com/graphql/graphql-playground/issues/741

Adding this here as there appears to be a copy of graphql-playground-html under the @apollographql namespace, and will possibly need to be updated when they fix this.

@ghost ghost added the 🌹 has-reproduction ❤ Has a reproduction in Glitch, CodeSandbox or Git repository. label Sep 29, 2018
@capaj
Copy link

capaj commented Oct 15, 2018

I have the same issue using the latest apollo-server-express 2.1.0

@nabeelz6
Copy link

nabeelz6 commented Oct 16, 2018

I think they might have fixed this and related setting persistence issues in prisma/graphql-playground repo:
graphql/graphql-playground#836

However, as @omgrief stated, there's a fork of playground under apollographql namespace (here?) that should pick up the new 1.8.0 release?

@javlund
Copy link

javlund commented Oct 19, 2018

Hi - I made a PR for it here, hope someone in charge will merge it: apollographql/graphql-playground#1

abernix added a commit that referenced this issue Oct 24, 2018
In addition to updating the `@apollographql/graphql-playground-html` fork,
which is necessary to avoid bundling `graphql-config` which had been
problematic in serverless environments, this updates the version number
which is served from the CDN.

I've just published `@apollographql/graphql-playground-html@1.6.4`.

Ref: #1746
Ref: apollographql/graphql-playground#2
Ref: apollographql/graphql-playground#1

Thanks for @javlund for kicking off some of this work!
@abernix abernix added this to the Release 2.2.0 milestone Oct 24, 2018
abernix added a commit that referenced this issue Oct 26, 2018
In addition to updating the `@apollographql/graphql-playground-html` fork,
which is necessary to avoid bundling `graphql-config` which had been
problematic in serverless environments, this updates the version number
which is served from the CDN.

I've just published `@apollographql/graphql-playground-html@1.6.4`.

Ref: #1746
Ref: apollographql/graphql-playground#2
Ref: apollographql/graphql-playground#1

Thanks for @javlund for kicking off some of this work!
ShiyamRajan pushed a commit to ShiyamRajan/apollo-server-lambda that referenced this issue Nov 2, 2018
In addition to updating the `@apollographql/graphql-playground-html` fork,
which is necessary to avoid bundling `graphql-config` which had been
problematic in serverless environments, this updates the version number
which is served from the CDN.

I've just published `@apollographql/graphql-playground-html@1.6.4`.

Ref: apollographql/apollo-server#1746
Ref: apollographql/graphql-playground#2
Ref: apollographql/graphql-playground#1

Thanks for @javlund for kicking off some of this work!
@Binarytales
Copy link

I'm still having this issue. I have created a reduced test case here: https://github.com/Binarytales/jubilant-octo-telegram

I originally posted this issue against graphql-playground directly here: graphql/graphql-playground#791 (comment)

@Binarytales
Copy link

Binarytales commented Jan 18, 2019

I've done a bit more digging and with the help of @HuVik I think that this issue wasn't actually fixed in graphql-playground till this PR graphql/graphql-playground#836 was released in version 1.8.0 (with 1.8.5 being that latest)

It looks like apollo-server is using 1.7.10: https://github.com/apollographql/apollo-server/blob/master/packages/apollo-server-core/src/playground.ts#L12

UPDATE: I'm still a bit confused about which versions of which packages have the needed fix and are or are not in use by various projects. However, for the benefit of future travellers stumbling across this thread I eventually discovered this post which was most illuminating: #1855 (comment)

@abernix abernix removed this from the Release 2.x milestone Jun 28, 2019
@thomsbg
Copy link

thomsbg commented Feb 21, 2020

I am still seeing this issue and have no workaround at the moment other than to wire up graphql-playground or graphiql manually. I am using apollo-server-express@2.10.1 and @apollographql/graphql-playground-html@1.6.24. Not being able to set 'request.credentials': 'include' means that this is unusable for my API which uses a session cookie for authentication.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🌹 has-reproduction ❤ Has a reproduction in Glitch, CodeSandbox or Git repository.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants