New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
request.credentials configuration is ignored #791
Comments
Thank you! I am noticing same thing where the setting change works for local session and then does not work on reload. |
I ran into this as well using Apollo Server. I hope it can be fixed. |
I ran into this with the koa playground. One twist: if I set |
I'm having the same behavior here. Some settings are used, while some are ignored in |
The server should just be able to push defaults over the defined defaults, which should then be overrideable by the settings screen in localStorage. So if I define serverside that It would also in this case be nice if there was a "Reset to defaults" button in the UI which deleted any local overrides and fall back to Playground defaults + server defined defaults. |
Same here, with |
Also seeing what @curry684 is describing. |
I've been following the code round and round, I can't for the life of me understand where it is that these settings are finally (supposed to be) merge together between the local storage, the server init, etc. Anyone could steer me in the right direction? |
This issue #796 is also related. |
I am trying to collect all these 'settings' issues in one place; I think it's beneficial that all of them are taken into consideration at once, lest we end up with partial fixes or fixes that break other stuff. Here's the place: #826 Could you all have a look and confirm the problem in this present issue has been captured in the one above? |
Why is the default setting omit?! |
@cyberdude See #470 |
I'm still running into the very same issue and it seems this was only fixed for Running this via Would appreciate some help here. If you need any more pointers please let me know 🙏 |
@boennemann Can you please provide minimal repo example? So i can look into that? |
@HuVik I have just got started with GraphQL recently and am experience the problem as @boennemann but with I have put together a minimal repo (https://github.com/Binarytales/jubilant-octo-telegram) showing that passing these playground settings
is not reflected when visiting |
@Binarytales they are using for of playground, so the best way is to contact them so they update it to use the latest version of |
Thank you for the quick response @HuVik I will raise an issue against However it does look like Latest version Version of Sorry if I've misunderstood anything about the relationship between these packages and their versions. When running my reduced test case if I inspect the initial index.html page I can see the correct settings being passed to
|
@Binarytales can you click on cogwheel and check number in the right bottom corner? That is a version of the playground included. |
@HuVik Ah yes I see now. It's It looks like this is indeed an issue with Thank you for your help. I'll see if I can raise a PR to the other project. UPDATE: For the benefit of future travellers stumbling across this thread I eventually discovered this post which was most illuminating: apollographql/apollo-server#1855 (comment) |
@Binarytales Yea, we already fixed one issue, why apollo did a fork of the playground. So maybe they could start using prisma version again. |
This issue pertains to the following package(s):
Setup:
The generated code confirms that the option is being passed:
However, viewing the configuration in the application (browser) shows that the setting did not have effect:
I have tried reseting the local storage values with no effect.
Changing the configuration using the application itself makes it work as expected for that local session.
The issue appears to be that
GraphQLPlayground.init
ignoresrequest.credentials
setting.Related issues:
The text was updated successfully, but these errors were encountered: