Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify explicit cursorShape to avoid missing cursor in GraphQL Playground. #1607

Merged
merged 5 commits into from Sep 20, 2018

Conversation

abernix
Copy link
Member

@abernix abernix commented Sep 3, 2018

This solves a problem with the text cursor caret not being visible in the
operation input box within GraphQL Playground by explicitly setting a
GraphQL Playground configuration option called cursorShape to line.

All credit for the actual solution goes to @lpellegr for their discovery in
graphql/graphql-playground#790 (comment)

…yground.

This solves a problem with the text cursor caret not being visible in the
operation input box within GraphQL Playground by explicitly setting a
GraphQL Playground configuration option called `cursorShape` to `line`.

All credit for the actual solution goes to @lpellegr for their discovery in
graphql/graphql-playground#790 (comment)
@elevenpassin
Copy link

OMG I NEED THIS SO MUCH, THX

@abernix
Copy link
Member Author

abernix commented Sep 4, 2018

I'm thrilled to say that this is already fixed thanks to a recent, more thorough fix thanks to @daggerjames's 984c47d as a result of #1516.

That change hadn't surfaced in an actual release yet when I submitted this PR, but it has been released as of apollo-server-*@2.0.6! 🎉

I'll happily close this in lieu of that more complete solution, and gladly tell myself "too little, too late!". 😉

Thanks, @daggerjames!

@abernix abernix closed this Sep 4, 2018
@abernix abernix deleted the abernix/graphql-playground-cursorshape-line branch September 4, 2018 07:07
@abernix abernix restored the abernix/graphql-playground-cursorshape-line branch September 5, 2018 19:05
@abernix
Copy link
Member Author

abernix commented Sep 7, 2018

While this isn't necessary with the default configuration for Apollo Server 2, I'm led to believe that this PR may still be necessary for those that are setting their own GraphQL Playground configuration (I don't in any of my projects so it's unnoticeable to me). Can anyone else corroborate that need? If so, I'll reopen and summon reviewers. 😉

@abernix abernix reopened this Sep 19, 2018
@abernix abernix merged commit 749538d into master Sep 20, 2018
@abernix abernix deleted the abernix/graphql-playground-cursorshape-line branch September 20, 2018 14:12
@abernix abernix mentioned this pull request Nov 16, 2018
4 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants