Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle for including error messages in reports #1615

Merged
merged 3 commits into from Sep 5, 2018

Commits on Sep 4, 2018

  1. add toggle for including error messages in reports

    We always send traces that includes an error node if the trace has an
    error. In the case that sending errors is disabled, we replace the
    message and remove the location.
    Evans Hauser committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    8e30c45 View commit details
    Browse the repository at this point in the history
  2. [Squash] Address feedback

    Note that the Engine proxy strips all error information from the traces
    with noErrorTraces set. To get errors to show up in the ui, the proxy
    sends error counts inside of the aggregated stats reports. To get
    similar behavior inside of the apollo server metrics reporting, we
    always send a trace and mask out the PII.
    Evans Hauser committed Sep 4, 2018
    Configuration menu
    Copy the full SHA
    6152862 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2018

  1. Configuration menu
    Copy the full SHA
    b04abe8 View commit details
    Browse the repository at this point in the history