Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency husky to v1 #1728

Merged
merged 3 commits into from Oct 10, 2018
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 26, 2018

This PR contains the following updates:

Package Type Update Change References
husky devDependencies major 0.14.3 -> 1.1.1 source

Release Notes

typicode/husky

v1.1.1

Compare Source

  • Check HUSKY_SKIP_INSTALL value first before checking if .git exists
  • Check Node version before running hooks

v1.1.0

Compare Source

  • Create .git/hooks if it doesn't exist

v1.0.1

Compare Source

v1.0.0

Compare Source

After a year of pre-releases and a complete rewrite, this marks the first stable release of husky 🐶🎉.

Notable changes

Below you'll find consolidated changes since 0.14.3. There's no change in code between 1.0.0-rc.15 and 1.0.0.

  • Hooks

    • Add sendemail-validate hook
  • Config

    • Move hooks config from scripts field to husky field
    • Prefer raw names for hooks (e.g. pre-commit rather than precommit)
    • Support .huskyrc config
  • Package managers

    • Support environments where yarn is the only package manager installed
    • Support pnpm package manager
  • Environment variables

    • Add HUSKY_SKIP_INSTALL environment variable for skipping git hooks installation
    • Add HUSKY_GIT_STDIN environment variable for pre-push, pre-receive, post-receive and post-rewrite to access arguments passed by Git via stdin
    • Rename GIT_PARAMS to HUSKY_GIT_PARAMS
  • Messages

    • Add many more messages in case of errors
    • Add please-upgrade-node message if using with unsupported Node version
    • Make --no-verify message more accurate and only show it for hooks that can be skipped
  • Upgrade

    • Add husky-upgrade command to automatically migrate hooks in package.json
    • Add deprecation warning for hooks that are still defined in scripts
  • Other

    • Drop Node 4 support
    • Drop integrated nvm support (see Node version management in docs)
Credits

Huge thanks to all the Contributors and Patreon Supporters! 🙏


Renovate configuration

📅 Schedule: "after 6pm every weekday,before 8am every weekday" in timezone America/Los_Angeles.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR is stale, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot added 🎄 dependencies Updates to dependencies, generally automatically managed by Renovate. 🛠 tooling Relates to tooling within the Apollo Server repository, not Apollo Server itself. labels Sep 26, 2018
@abernix
Copy link
Member

abernix commented Sep 26, 2018

👋 @rarkins This is an npm bug, right?

...And if so, and I wanted to re-trigger this, am I correct in understanding that this instruction:

you rename then delete this PR unmerged, so that it can be regenerated.

...means:

  1. Rename the PR subject.
  2. Close the PR un-merged.

@rarkins
Copy link
Contributor

rarkins commented Sep 26, 2018

@abernix I'm not certain of the cause, but I do know a much easier way to try again. You can simply add the label "rebase" to this PR and Renovate will recreate/rebase it on the next cycle (hourly).

@abernix abernix added the rebase label Sep 26, 2018
@abernix
Copy link
Member

abernix commented Sep 26, 2018

That is a much easier way. Thank you, @rarkins!

@renovate renovate bot removed the rebase label Sep 26, 2018
@renovate renovate bot force-pushed the renovate/husky-1.x branch 2 times, most recently from d6a82c9 to 16b5042 Compare September 27, 2018 04:50
@rarkins
Copy link
Contributor

rarkins commented Sep 27, 2018

@abernix seems that this problem is not entirely ephemeral. My best guess is that this might be a disk space issue even though (a) I'm not seeing any explicit mention of that in the above log, (b) I'm not getting disk space alerts from AWS, and (c) I'm not sure what would have changed in the past couple of days to take up more disk space.

Obviously the change to using a "full" install a few weeks back because of the npm bug would have caused a major increase in disk used, but we didn't see this problem then.

@rarkins
Copy link
Contributor

rarkins commented Sep 27, 2018

Maybe it's not disk space. Searches in the npm repos and npm.community lead to the best hope being that this PR might fix it once landed in a release: npm/cli#40

I'm not 100% sure though

@rarkins
Copy link
Contributor

rarkins commented Sep 27, 2018

@abernix maybe you could consider a manual refresh of your package-lock.json file(s) in master branch and seeing if that magically does the trick as some people indicated? i.e. an "opportunity" to update any ranges or transitive dependencies to most recent versions by deleting the lock file and recreating from scratch. Merge after tests of course :)

@renovate renovate bot force-pushed the renovate/husky-1.x branch 7 times, most recently from 8d13c54 to e6debb9 Compare October 1, 2018 16:19
@codecov-io
Copy link

codecov-io commented Oct 1, 2018

Codecov Report

Merging #1728 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1728   +/-   ##
=======================================
  Coverage   73.82%   73.82%           
=======================================
  Files          29       29           
  Lines        1150     1150           
  Branches      288      288           
=======================================
  Hits          849      849           
  Misses        291      291           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9121b1...0b05bdc. Read the comment docs.

@rarkins
Copy link
Contributor

rarkins commented Oct 1, 2018

@abernix looks like it autofixed itself eventually.. merge it while it's hot ;)

@renovate renovate bot force-pushed the renovate/husky-1.x branch 7 times, most recently from a93823e to c427d03 Compare October 4, 2018 20:02
@renovate renovate bot force-pushed the renovate/husky-1.x branch 7 times, most recently from 04264da to 8a6a336 Compare October 9, 2018 09:38
@abernix abernix added the rebase label Oct 9, 2018
@renovate renovate bot removed the rebase label Oct 9, 2018
@renovate
Copy link
Contributor Author

renovate bot commented Oct 10, 2018

⚠️ Lock file problem

Renovate failed to update a lock file. You probably do not want to merge this PR as-is.

♻️ Renovate will retry this branch, including lockfile, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The lock file failure details are included below:

package-lock.json
npm WARN @apollographql/apollo-upload-server@5.0.3 requires a peer of graphql@^0.13.1 but none is installed. You must install peer dependencies yourself.
npm WARN apollo-link-persisted-queries@0.2.1 requires a peer of graphql@^0.11.0 || ^0.12.0 || ^0.13.0 but none is installed. You must install peer dependencies yourself.
npm WARN graphql-subscriptions@0.5.8 requires a peer of graphql@^0.10.5 || ^0.11.3 || ^0.12.0 || ^0.13.0 but none is installed. You must install peer dependencies yourself.
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.4 (node_modules/fsevents):
npm WARN enoent SKIPPING OPTIONAL DEPENDENCY: ENOENT: no such file or directory, rename '/mnt/renovate/gh/apollographql/apollo-server/node_modules/.staging/fsevents-37a5ed8f/node_modules/abbrev' -> '/mnt/renovate/gh/apollographql/apollo-server/node_modules/.staging/abbrev-6e39ca20'

npm ERR! path /mnt/renovate/gh/apollographql/apollo-server/node_modules/.staging/apollo-server-core-14508698/node_modules/ws
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall rename
npm ERR! enoent ENOENT: no such file or directory, rename '/mnt/renovate/gh/apollographql/apollo-server/node_modules/.staging/apollo-server-core-14508698/node_modules/ws' -> '/mnt/renovate/gh/apollographql/apollo-server/node_modules/.staging/ws-b1d8e3b8'
npm ERR! enoent This is related to npm not being able to find a file.
npm ERR! enoent 

npm ERR! A complete log of this run can be found in:
npm ERR!     /tmp/renovate/npm-cache/_logs/2018-10-10T13_54_08_362Z-debug.log

@renovate renovate bot force-pushed the renovate/husky-1.x branch 3 times, most recently from 6513b4e to 07a6919 Compare October 10, 2018 13:34
@renovate
Copy link
Contributor Author

renovate bot commented Oct 10, 2018

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over then you can add the label rebase to this PR and Renovate will reset/recreate it.

@abernix abernix merged commit 1102887 into master Oct 10, 2018
@renovate renovate bot deleted the renovate/husky-1.x branch October 10, 2018 14:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🎄 dependencies Updates to dependencies, generally automatically managed by Renovate. 🛠 tooling Relates to tooling within the Apollo Server repository, not Apollo Server itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants