Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correct project references for apollo-server-cloud-functions. #1948

Merged
merged 2 commits into from Nov 12, 2018

Commits on Nov 12, 2018

  1. Add correct project references for apollo-server-cloud-functions.

    The `apollo-server-cloud-functions` has been been mis-referenced (or
    referenced inconsistently) since its original inception in #1446 when its
    package directory was `apollo-server-cloud-function` (singular!) and the
    `package.json` referenced the plural form (`apollo-server-cloud-functions`):
    
    724d9ff0#diff-e1d725fd66f7e9ef5251abf0437a09ca
    
    These references have been mostly fixed in the READMEs and supporting
    documentation, but the underlying monorepo directory structure has still not
    been fixed, which I'm sure contributed to this module being overlooked and
    unreferenced in the move to TypeScript project references in #1772.
    
    Additionally, the lack of referencing in the monorepo's TS config has
    resulted in it being broken in the most recent 2.2.0 release, as reported by
    @pyros2097 and @thetre97 in: #1896 (comment)
    
    This should fix that by properly adding the TypeScript project references.
    abernix committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    93d09b1 View commit details
    Browse the repository at this point in the history
  2. Sorting.

    abernix committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    575a95e View commit details
    Browse the repository at this point in the history