Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

AER: include encodedTraces only once to prevent duplicates #2040

Merged
merged 14 commits into from Dec 4, 2018

Commits on Nov 29, 2018

  1. AER: Remove encodedTraces to prevent duplicates

    When there are multiple instances of apollo-engine-reporting, the
    `Trace.encode` method gets wrapped each time to add the
    `encodedTraces`. In order to prevent them from being added to the
    protobuf multiple times, we remove the encodedTraces after adding them
    once
    Evans Hauser committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    5f9f86b View commit details
    Browse the repository at this point in the history
  2. Add changelog

    Evans Hauser committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    2188b50 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'master' into evans/fix-duplicate-aer

    Evans Hauser committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    a71f7ad View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2018

  1. Merge branch 'master' into evans/fix-duplicate-aer

    Evans Hauser committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    0f956b5 View commit details
    Browse the repository at this point in the history
  2. Move incremental Trace encoding to a-e-r-protobuf

    To enable incrmental compilation of traces, we add a patch to the
    Trace.encode method generated by protobujs to accept and store encoded
    traces. Occassionally with multiple instances of apollo-engine-reporting
    that share the same version of the protobuf, the wrapper method gets
    applied more than once. In order to ensure that the wrapper only gets
    applied once, we patch the Trace.encode method inside of
    apollo-engine-protobuf.
    
    tsc hangs on the processing the generated protobuf.js files, so the
    tsconfig.json ignores the generated protobuf file. In order for the
    typescript index.ts file to compile the generated protobuf.js file is
    output to the src folder. To ensure the protobuf files are available to
    the production build, `npm run compile` copies the protobuf file
    manually from src to dist.
    Evans Hauser committed Nov 30, 2018
    Configuration menu
    Copy the full SHA
    844563a View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2018

  1. Reexport protobuf import after modification

    `export * from './protobuf'` exports the unmodified reference
    Evans Hauser committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    a027334 View commit details
    Browse the repository at this point in the history
  2. Update comment on Trace.encode to point at a-e-r-p

    The override now occurs inside of apollo-engine-reporting-protobuf due
    to the case of having multiple reporting challenges, so we need to
    update the comments to help indicate that
    Evans Hauser committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    f756174 View commit details
    Browse the repository at this point in the history
  3. Remove typescript build step

    In order to simplify the generation of this library, we move the change
    the index.ts file into index.js and remove the typescript build step.
    Since the type safety is created by the protobufjs generation, this
    seems acceptable. In general this portion of the code should remain
    relatively stable, so generating and copying the code with `prepare`
    remains reasonable.
    Evans Hauser committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    36c46bc View commit details
    Browse the repository at this point in the history
  4. Add description of dev process in README

    Evans Hauser committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    b533e45 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2018

  1. Merge branch 'master' into evans/fix-duplicate-aer

    Evans Hauser committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    f45c549 View commit details
    Browse the repository at this point in the history
  2. Update CHANGELOG.md

    abernix committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    04ba11a View commit details
    Browse the repository at this point in the history
  3. Update README.md

    abernix committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    2f590d1 View commit details
    Browse the repository at this point in the history
  4. Update README.md

    abernix committed Dec 4, 2018
    Configuration menu
    Copy the full SHA
    05a2e4b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    307c4f1 View commit details
    Browse the repository at this point in the history