Switch json-stable-stringify to fast-json-stable-stringify.
#2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtgtybhertgeghgtwtg
requested review from
abernix and
martijnwalraven
as code owners
|
Thank you, @wtgtybhertgeghgtwtg! 🔮💭 |
abernix
added a commit
that referenced
this pull request
Jan 25, 2019
I've switched this to the same library used by the main repository for consistency and licensing purposes. The local depdendency by the operation registry will actually go away in a future update now that it's supported by the core server implementation.
trevor-scheer
pushed a commit
that referenced
this pull request
May 6, 2020
I've switched this to the same library used by the main repository for consistency and licensing purposes. The local depdendency by the operation registry will actually go away in a future update now that it's supported by the core server implementation.
trevor-scheer
pushed a commit
that referenced
this pull request
May 6, 2020
As of #2065, we no longer use `json-stable-stringify`, which pulled in `jsonify` — a dependency which is licensed under a public-domain license which is not agreeable with some organizations. The `fast-json-stable-stringify` license does not rely on `jsonify`. This swaps the package being licensed, but the license itself is the same (MIT).
trevor-scheer
pushed a commit
that referenced
this pull request
May 12, 2020
As of #2065, we no longer use `json-stable-stringify`, which pulled in `jsonify` — a dependency which is licensed under a public-domain license which is not agreeable with some organizations. The `fast-json-stable-stringify` license does not rely on `jsonify`. This swaps the package being licensed, but the license itself is the same (MIT).
trevor-scheer
pushed a commit
that referenced
this pull request
May 14, 2020
I've switched this to the same library used by the main repository for consistency and licensing purposes. The local depdendency by the operation registry will actually go away in a future update now that it's supported by the core server implementation.
trevor-scheer
pushed a commit
that referenced
this pull request
May 14, 2020
As of #2065, we no longer use `json-stable-stringify`, which pulled in `jsonify` — a dependency which is licensed under a public-domain license which is not agreeable with some organizations. The `fast-json-stable-stringify` license does not rely on `jsonify`. This swaps the package being licensed, but the license itself is the same (MIT).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So,
json-stable-stringifypulls injsonify, which causes legal trouble for some companies because it's licensed under Public Domain. This swaps it with a version that doesn't.fast-json-stable-stringifyis actually already in the dependency tree, sinceapollo-utilitiesuses it.