Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.4.0 #2215

Merged
merged 31 commits into from
Feb 7, 2019
Merged

Release 2.4.0 #2215

merged 31 commits into from
Feb 7, 2019

Commits on Dec 18, 2018

  1. Configuration menu
    Copy the full SHA
    b30e933 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    88a294b View commit details
    Browse the repository at this point in the history
  3. Publish

     - apollo-cache-control@0.5.0-alpha.0
     - apollo-datasource-rest@0.3.0-alpha.0
     - apollo-datasource@0.3.0-alpha.0
     - apollo-engine-reporting@0.3.0-alpha.0
     - apollo-server-azure-functions@2.4.0-alpha.0
     - apollo-server-cache-memcached@0.3.0-alpha.0
     - apollo-server-cache-redis@0.3.0-alpha.0
     - apollo-server-caching@0.3.0-alpha.0
     - apollo-server-cloud-functions@2.4.0-alpha.0
     - apollo-server-cloudflare@2.4.0-alpha.0
     - apollo-server-core@2.4.0-alpha.0
     - apollo-server-express@2.4.0-alpha.0
     - apollo-server-hapi@2.4.0-alpha.0
     - apollo-server-integration-testsuite@2.4.0-alpha.0
     - apollo-server-koa@2.4.0-alpha.0
     - apollo-server-lambda@2.4.0-alpha.0
     - apollo-server-micro@2.4.0-alpha.0
     - apollo-server-plugin-base@0.3.0-alpha.0
     - apollo-server-testing@2.4.0-alpha.0
     - apollo-server@2.4.0-alpha.0
     - apollo-tracing@0.5.0-alpha.0
     - graphql-extensions@0.5.0-alpha.0
    abernix committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    7697623 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2019

  1. Configuration menu
    Copy the full SHA
    ea7da3a View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2019

  1. Configuration menu
    Copy the full SHA
    45f14a2 View commit details
    Browse the repository at this point in the history
  2. Ensure requestContext.document set, irregardless of documentStore

    … use.
    
    Without this change, the `document` property was not set on the
    `requestContext` for consumption by request pipeline plugins.
    
    To further guard against this oversight, I've removed the extra `document`
    variable which was being used as scoped state for the document and switched to
    directly using (and assigning to) the `requestContext.document`.
    
    Nice catch, @glasser!
    
    Ref: https://github.com/apollographql/apollo-server/pull/2111/files#r247617469
    abernix committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    f33ae19 View commit details
    Browse the repository at this point in the history
  3. Clarify comments surrounding documentStore, which led to confusion.

    The parsed/validated cache store is on by default.  While it could be disabled,
    in theory, it cannot be disabled since its an internal property of the
    request pipeline processor class.
    
    See confusion here:
    
      withspectrum/spectrum#4533 (comment)
    abernix committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    2652057 View commit details
    Browse the repository at this point in the history
  4. Fix typos/spacing in commentary.

    Of my own making!
    abernix committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    f546086 View commit details
    Browse the repository at this point in the history
  5. Guard against (currently impossible) failure to read from `documentSt…

    …ore`.
    
    While the implementation of the `documentStore` is currently simple enough
    to never throw (it is in-memory), it makes some sense to guard against future
    extended functionality where an exception might be raised.
    
    Since storing this object in a distributed memory store isn't currently
    feasible, I'm not sure what such an exception would be right now, but I
    don't mind being proactive!
    
    Ref: https://github.com/apollographql/apollo-server/pull/2111/files#r247618501
    abernix committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    1a9d65d View commit details
    Browse the repository at this point in the history
  6. Be considerate of variable length utf-8 encodings in InMemoryLRUCache.

    Previously, this used the `JSON.stringify` length, but this is slightly more
    aware.
    abernix committed Jan 15, 2019
    Configuration menu
    Copy the full SHA
    0879a12 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2019

  1. Shift the burden of object approximation into the ApolloServerBase

    …class.
    
    The implementation of object-size approximation which is used for cache
    eviction purposes in the `InMemoryLRUCache` implementation (via `lru-cache`)
    was a short-term location for extensible logic which is better located
    within `ApolloServerBase`.
    
    This is particularly important since future logic may necessitate knowing or
    understanding the current size (roughly, memory usage) of the in-memory
    storage.  Effective immediately, this adds support for providing a `dispose`
    function which is called when an object is purged from the cache to make
    room for another.
    abernix committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    be71620 View commit details
    Browse the repository at this point in the history
  2. [debug] Print out documentStore stats every 60 seconds.

    In an effort to see how effective this cache is in production during this
    alpha phase, we'll print out the stats on the document store every 60
    seconds.
    abernix committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    7a0d0e6 View commit details
    Browse the repository at this point in the history
  3. Publish

     - apollo-cache-control@0.5.0-alpha.1
     - apollo-datasource-rest@0.3.0-alpha.1
     - apollo-datasource@0.3.0-alpha.1
     - apollo-engine-reporting@0.3.0-alpha.1
     - apollo-server-azure-functions@2.4.0-alpha.1
     - apollo-server-cache-memcached@0.3.0-alpha.1
     - apollo-server-cache-redis@0.3.0-alpha.1
     - apollo-server-caching@0.3.0-alpha.1
     - apollo-server-cloud-functions@2.4.0-alpha.1
     - apollo-server-cloudflare@2.4.0-alpha.1
     - apollo-server-core@2.4.0-alpha.1
     - apollo-server-express@2.4.0-alpha.1
     - apollo-server-hapi@2.4.0-alpha.1
     - apollo-server-integration-testsuite@2.4.0-alpha.1
     - apollo-server-koa@2.4.0-alpha.1
     - apollo-server-lambda@2.4.0-alpha.1
     - apollo-server-micro@2.4.0-alpha.1
     - apollo-server-plugin-base@0.3.0-alpha.1
     - apollo-server-testing@2.4.0-alpha.1
     - apollo-server@2.4.0-alpha.1
     - apollo-tracing@0.5.0-alpha.1
     - graphql-extensions@0.5.0-alpha.1
    abernix committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    33d1f82 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2019

  1. Revert (as intended!) "[debug] Print out documentStore stats every 60…

    … seconds."
    
    This reverts commit 7a0d0e6, as I intended
    when I originally introduced it.
    
    Ref: #2111 (comment)
    abernix committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    2ed1c0e View commit details
    Browse the repository at this point in the history
  2. Publish

     - apollo-server-azure-functions@2.4.0-alpha.2
     - apollo-server-cloud-functions@2.4.0-alpha.2
     - apollo-server-cloudflare@2.4.0-alpha.2
     - apollo-server-core@2.4.0-alpha.2
     - apollo-server-express@2.4.0-alpha.2
     - apollo-server-hapi@2.4.0-alpha.2
     - apollo-server-integration-testsuite@2.4.0-alpha.2
     - apollo-server-koa@2.4.0-alpha.2
     - apollo-server-lambda@2.4.0-alpha.2
     - apollo-server-micro@2.4.0-alpha.2
     - apollo-server-plugin-base@0.3.0-alpha.2
     - apollo-server-testing@2.4.0-alpha.2
     - apollo-server@2.4.0-alpha.2
     - graphql-extensions@0.5.0-alpha.2
    abernix committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    1d00219 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #2111 from apollographql/abernix/cache-parsed-vali…

    …dated
    
    Cache successfully parsed and validated documents for future requests.
    abernix committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    7d54688 View commit details
    Browse the repository at this point in the history
  4. feat(Fastify) Apollo server Fastify integration #626 (#1971)

    * feat(fastify) Apollo Fastify server integration resolve #626
    
    * feat(fastify) Use createHandler instead of applyMiddleware #626
    
    * feat(fastify) Fix integration test for node 10 #626
    
    * feat(fastify) Update README's with fastify createHandler interface #626
    
    * feat(fastify) Implement the fastify createHandler as a synchronous method #626
    
    * (fastify) Tweaks to re-align with the parallel work in #2054.
    
    * (fastify): Use port 9999 rather than 8888 for tests.  Because Gatsby.
    
    This specific port per integration is pretty brittle to begin with, but it
    does work.  Currently, the fact that it works is facilitated by the fact
    that most people don't use 5555 (Hapi) and 6666 (Express) for anything.
    
    That said, the ever-popular Gatsby uses 8888 by default, so let's use 9999!
    
    * (fastify) Remove duplicative assertion in upload initialization.
    
    * (fastify) Implement fastify upload middleware
    
    * (fastify) Fix linting issues
    
    * (fastify) Update package-lock
    rkorrelboom authored and abernix committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    069110b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e82bccf View commit details
    Browse the repository at this point in the history
  6. Bump apollo-server-fastify to match last 2.4.0-alpha.x release.

    This will cause the first release of `apollo-server-fastify` to land at
    `2.4.0-alpha.3`.  (Hopefully.)
    abernix committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    a550dfc View commit details
    Browse the repository at this point in the history
  7. Publish

     - apollo-cache-control@0.5.0-alpha.2
     - apollo-datasource-rest@0.3.0-alpha.2
     - apollo-datasource@0.3.0-alpha.2
     - apollo-engine-reporting@0.3.0-alpha.2
     - apollo-server-azure-functions@2.4.0-alpha.3
     - apollo-server-cache-memcached@0.3.0-alpha.2
     - apollo-server-cache-redis@0.3.0-alpha.2
     - apollo-server-caching@0.3.0-alpha.2
     - apollo-server-cloud-functions@2.4.0-alpha.3
     - apollo-server-cloudflare@2.4.0-alpha.3
     - apollo-server-core@2.4.0-alpha.3
     - apollo-server-express@2.4.0-alpha.3
     - apollo-server-fastify@2.4.0-alpha.3
     - apollo-server-hapi@2.4.0-alpha.3
     - apollo-server-integration-testsuite@2.4.0-alpha.3
     - apollo-server-koa@2.4.0-alpha.3
     - apollo-server-lambda@2.4.0-alpha.3
     - apollo-server-micro@2.4.0-alpha.3
     - apollo-server-plugin-base@0.3.0-alpha.3
     - apollo-server-testing@2.4.0-alpha.3
     - apollo-server@2.4.0-alpha.3
     - apollo-tracing@0.5.0-alpha.2
     - graphql-extensions@0.5.0-alpha.3
    abernix committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    f045a4d View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2019

  1. Configuration menu
    Copy the full SHA
    03283f9 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2019

  1. Configuration menu
    Copy the full SHA
    21c4c11 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2019

  1. Configuration menu
    Copy the full SHA
    d0998e7 View commit details
    Browse the repository at this point in the history
  2. chore(deps): update dependency @types/koa-bodyparser to a valid 4.2.1… (

    #2217)
    
    … version
    
    This PR should hopefully correct some typing issues we are currently facing.
    
    The problem:
    - this package references v5.0.1 for @types/koa-bodyparser
    - when we start our server that also uses koa-bodyparser for non-graphql routes, the type for koa.Request sets the "body" field to:
    
    ```
    declare module "koa" {
        interface Request {
            body: {} | null | undefined;
            rawBody: {} | null | undefined;
        }
    }
    ```
    
    Which breaks our type defs for koa-bodyparser as we actually want "body" to be set to "any."
    
    The v5.0.1 that was originally placed here is no longer "latest" and they have published a new v4 version that has the correct typing for koa-bodyparser (setting body to any). - https://www.npmjs.com/package/@types/koa-bodyparser
    
    <!--
      Thanks for filing a pull request on GraphQL Server!
    
      Please look at the following checklist to ensure that your PR
      can be accepted quickly:
    -->
    
    TODO:
    
    * [ ] Update CHANGELOG.md with your change (include reference to issue & this PR)
    * [x] Make sure all of the significant new logic is covered by tests
    * [x] Rebase your changes on master so that they can be merged easily
    * [x] Make sure all tests and linter rules pass
    dennis-johnson-dev authored and abernix committed Feb 4, 2019
    Configuration menu
    Copy the full SHA
    9594997 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4b8dc7c View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2019

  1. Configuration menu
    Copy the full SHA
    5666235 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2019

  1. Configuration menu
    Copy the full SHA
    60b8bca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f4dc913 View commit details
    Browse the repository at this point in the history
  3. TEMP: Revert "feat(Fastify) Apollo server Fastify integration #626 (#…

    …1971)"
    
    This TEMPORARILY reverts commit 069110b,
    which was the result of the work done in #1971 by @rkorrelboom.
    
    Unfortunately, we need to put this on ice while we wait for movement on a
    package naming conflict.  The dialog surrounding this is under way, as
    I've explained in the PR:
    
    #1971 (comment)
    
    I'm excited to re-land this in an upcoming version, but there's no reason to
    block the 2.4.0 release for it right now.
    
    I will open a new PR with the work from #1971 in due time.
    abernix committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    e971bdf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    44358ef View commit details
    Browse the repository at this point in the history
  5. Publish

     - apollo-cache-control@0.5.0-alpha.3
     - apollo-datasource-rest@0.3.0-alpha.3
     - apollo-engine-reporting@1.0.0-alpha.3
     - apollo-graphql@0.0.1-alpha.1
     - apollo-server-azure-functions@2.4.0-alpha.4
     - apollo-server-cloud-functions@2.4.0-alpha.4
     - apollo-server-cloudflare@2.4.0-alpha.4
     - apollo-server-core@2.4.0-alpha.4
     - apollo-server-express@2.4.0-alpha.4
     - apollo-server-hapi@2.4.0-alpha.4
     - apollo-server-integration-testsuite@2.4.0-alpha.4
     - apollo-server-koa@2.4.0-alpha.4
     - apollo-server-lambda@2.4.0-alpha.4
     - apollo-server-micro@2.4.0-alpha.4
     - apollo-server-plugin-base@0.3.0-alpha.4
     - apollo-server-testing@2.4.0-alpha.4
     - apollo-server@2.4.0-alpha.4
     - apollo-tracing@0.5.0-alpha.3
     - graphql-extensions@0.5.0-alpha.4
    abernix committed Feb 7, 2019
    Configuration menu
    Copy the full SHA
    f74610b View commit details
    Browse the repository at this point in the history