Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing parseOptions to ApolloServerBase constructor. #2289

Merged
merged 5 commits into from Feb 12, 2019
Merged

Allow passing parseOptions to ApolloServerBase constructor. #2289

merged 5 commits into from Feb 12, 2019
+45 −18

Commits on Feb 12, 2019

  1. Pass noLocation:true to schema parser by default.

    @benjamn
    benjamn committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    ccff9c3 View commit details
    Browse the repository at this point in the history

  2. Revert noLocation:true as default, but preserve parseOptions. 

    Thanks to @abernix for his thoughtful objections in this comment:
#2289 (review)
    @benjamn
    benjamn committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    06459a1 View commit details
    Browse the repository at this point in the history

  3. Reuse parseOptions when parsing queries.

    @benjamn
    benjamn committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    44f2dc8 View commit details
    Browse the repository at this point in the history

  4. Humor prettier complaints.

    @benjamn
    benjamn committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    29870ab View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into parse-schema-with-noLocation-by-default

    @benjamn
    benjamn committed Feb 12, 2019
    Configuration menu
    Copy the full SHA
    4b1319f View commit details
    Browse the repository at this point in the history