Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ws import error for typescript #2323

Closed
wants to merge 2 commits into from

Conversation

BranLiang
Copy link

@BranLiang BranLiang commented Feb 14, 2019

Simple fix an error encountered when using apollo-server-core directly

screen shot 2019-02-14 at 10 42 35 pm

Related issues:

#2110

TODO:

Problem could be solved with specific typescript compile configuration, and this is why no error occurs in project, but could not be used in other personal project.

"esModuleInterop": true
  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@apollo-cla
Copy link

@BranLiang: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@abernix
Copy link
Member

abernix commented Feb 21, 2019

Thanks for opening this, but this should already be fixed thanks to #2230, and specifically, c1607cb. That fix should be included in Apollo Server 2.4.3. Please test and feel free to ping back if it doesn't solve it for you.

Thanks again!

@abernix abernix closed this Feb 21, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants