Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

export ExpressContext #2352

Merged
merged 2 commits into from Feb 21, 2019
Merged

export ExpressContext #2352

merged 2 commits into from Feb 21, 2019

Conversation

KATT
Copy link
Contributor

@KATT KATT commented Feb 21, 2019 •
edited

Original: #2349

Kept some tiny stuff that has very little value now, but anyway 🤷‍♂️

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@KATT KATT force-pushed the express-context branch 4 times, most recently from fa954b9 to defd741 Compare February 21, 2019 18:31
@KATT KATT marked this pull request as ready for review February 21, 2019 18:32
cheapsteak
cheapsteak approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@cheapsteak cheapsteak left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!
Thanks so much for this, and also appreciate your work on #2349 as well (and apologies for the mixup that caused that bug, hope it didn't cause you to lose too much time)

update: released as 2.4.5

@cheapsteak cheapsteak mentioned this pull request Feb 21, 2019
Merged
4 tasks
@cheapsteak cheapsteak merged commit 2a9ad9f into apollographql:master Feb 21, 2019
@cheapsteak cheapsteak changed the title Express context export Express context Feb 21, 2019
@cheapsteak cheapsteak changed the title export Express context export ExpressContext Feb 21, 2019
@KATT KATT deleted the express-context branch February 22, 2019 13:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cheapsteak cheapsteak cheapsteak approved these changes

@abernix abernix Awaiting requested review from abernix

@martijnwalraven martijnwalraven Awaiting requested review from martijnwalraven

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KATT @cheapsteak