Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove incorrect cors option type from apollo-server-express's constructor #2373

Merged
merged 3 commits into from Feb 25, 2019

Conversation

cheapsteak
Copy link
Member

@cheapsteak cheapsteak commented Feb 25, 2019

Fixes problem brought up in #2330 (comment) - cors options can only be applied to the standalone apollo-server's constructor, for apollo-server-express, their constructor can't contain cors settings, the option is only read from applyMiddleware

TODO:

  • Update CHANGELOG.md with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests (NA)
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@abernix abernix merged commit 1ef592a into master Feb 25, 2019
@abernix abernix deleted the chang/fix/constructor-cors-typing branch February 25, 2019 15:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants