Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UniqueDirectivesPerLocation import #3741

Merged
merged 2 commits into from Jan 31, 2020

Conversation

trevor-scheer
Copy link
Member

@trevor-scheer trevor-scheer commented Jan 30, 2020

This update is in response to the following PRs:
graphql/graphql-js#2400
graphql/graphql-js#2413

cc @IvanGoncharov, thank you for the changes in ^2413!

@IvanGoncharov
Copy link
Member

@trevor-scheer Looks great 👍
Hopefully, by us working together, the Apollo user will be able to just npm update graphql on a day1 of 15.0.0 release.

@abernix abernix merged commit 5e9054c into master Jan 31, 2020
@abernix abernix deleted the trevor/update-uniquedirectivesrule-import branch January 31, 2020 11:26
@abernix abernix added this to the Release 2.10.0 milestone Jan 31, 2020
abernix pushed a commit to apollographql/federation that referenced this pull request Sep 4, 2020
…ver#3741)

This update is in response to the below referenced PRs.

The `UniqueDirectivesPerLocationRule` has been exported at the root since forever (at least 0.12.0.

graphql/graphql-js#2400
graphql/graphql-js#2413
Apollo-Orig-Commit-AS: apollographql/apollo-server@5e9054c
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants