Use optional chaining across the entire repo #5609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamn
reviewed
Aug 12, 2021
IvanGoncharov
added a commit
to IvanGoncharov/apollo-server
that referenced
this pull request
Aug 12, 2021
It should safe to use `typeof` & `instanceof` on any value including `null` and `undefined`. Also `isObjectType` accepts any value so no need to prefix it with nullable check. I spot these places during apollographql#5609
| @@ -217,7 +217,7 @@ export async function processGraphQLRequest<TContext>( | |||
| } catch (err) { | |||
| logger.warn( | |||
| 'An error occurred while attempting to read from the documentStore. ' + | |||
| (err && err.message) || err, | |||
| err?.message || err, | |||
There was a problem hiding this comment.
Would you be interested in updating these usages of || to the null coalesce ?? operator as well? Keeping in mind the slight functional difference between the two (i.e. if err?.message === ''). Possibly a separate PR.
Suggested change
| err?.message || err, | |
| err?.message ?? err, |
trevor-scheer
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
LGTM, barring @benjamn's suggestion and whether or not you'd like to also tackle the ?? update as well.
Co-authored-by: Ben Newman <ben@benjamn.com>
|
Did you find these automatically somehow? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pure mechanical change, shouldn't affect anything 馃檹