Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't override custom code extensions from scalar parseValue errors #7183

Merged
merged 3 commits into from Nov 23, 2022
Merged

Don't override custom code extensions from scalar parseValue errors #7183

merged 3 commits into from Nov 23, 2022

Commits on Nov 22, 2022

  1. Don't override custom code extensions from scalar parseValue errors 

    Adding `BAD_USER_INPUT` is a nice default (and overrides the
inappropriate default of `INTERNAL_SERVER_ERROR`) but if somebody has
set a `code` already, we shouldn't override.

(Note that there's a separate issue where graphql-js throws out
extensions from the thrown error itself and only pays attention to
extensions on the error's originalError; we're trying to fix that in
graphql/graphql-js#3785 but this is orthogonal.)

Fixes #7178.
    @glasser
    glasser committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    4f58f0e View commit details
    Browse the repository at this point in the history

  2. Update packages/server/src/requestPipeline.ts 

    Co-authored-by: Trevor Scheer <trevor.scheer@gmail.com>
    @glasser @trevor-scheer
    glasser and trevor-scheer committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    eccbab2 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. Update packages/server/src/requestPipeline.ts

    @glasser
    glasser committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    527f787 View commit details
    Browse the repository at this point in the history