Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't install the usage reporting plugin by default in subgraphs #7184

Merged
merged 4 commits into from Nov 23, 2022
Merged

Don't install the usage reporting plugin by default in subgraphs #7184

merged 4 commits into from Nov 23, 2022

Commits on Nov 22, 2022

  1. Update terminology around subgraphs 

    Various log messages and internal symbol names and comments referred to
"federated service" rather than the newer and clearer "subgraph".
    @glasser
    glasser committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    6ebca53 View commit details
    Browse the repository at this point in the history

  2. Don't install the usage reporting plugin by default in subgraphs 

    The usage reporting plugin is designed for monolithic graphs and
Gateways, not for subgraphs. You will get strange results in
GraphOS/Studio if you send usage reports from a subgraph to Studio. This
PR changes the defaults so that subgraphs do not automatically install
the usage reporting plugin even if API key and graph ref are provided;
in this case, a warning is logged.

You still can explicitly install ApolloServerPluginUsageReporting in
subgraphs, though a warning will be logged.

Fixes #7121.
    @glasser
    glasser committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    7e2cbc3 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Danielle Man <man.danielleh@gmail.com>
    @glasser @daniman
    glasser and daniman committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    4428081 View commit details
    Browse the repository at this point in the history

  2. Update packages/server/src/plugin/usageReporting/options.ts 

    Co-authored-by: Trevor Scheer <trevor.scheer@gmail.com>
    @glasser @trevor-scheer
    glasser and trevor-scheer committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    6bd943d View commit details
    Browse the repository at this point in the history