Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @apollo/utils.keyvaluecache dependency #7187

Merged
merged 3 commits into from Nov 23, 2022

Conversation

trevor-scheer
Copy link
Member

Previous releases of the @apollo/utils.keyvaluecache package improperly specified the version range for its lru-cache dependency.

Fresh installs of our packages should receive the patch update since it's careted, so this issue can be worked around by forcing the update if you're using a lockfile. We should update it anyway since 2.0.0 is invalid.

Previous releases of this package improperly specified the version
range for its `lru-cache` dependency.
@netlify
Copy link

netlify bot commented Nov 23, 2022

Deploy Preview for apollo-server-docs ready!

Name Link
🔨 Latest commit 7431009
🔍 Latest deploy log https://app.netlify.com/sites/apollo-server-docs/deploys/637e6ce98e59fe0008174836
😎 Deploy Preview https://deploy-preview-7187--apollo-server-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 23, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7431009:

Sandbox Source
Apollo Server Typescript Configuration
Apollo Server Configuration

Copy link
Member

@glasser glasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is published let's hop over to an integration repo and see if updating to this version requires that repo to also add lib: ['dom'] or skipLibCheck: true (and if so, update our README or something).

@trevor-scheer
Copy link
Member Author

The built packages from this PR seem to build and test ok in our next and hapi integration repos, so I think this is ok!

@trevor-scheer trevor-scheer merged commit 3fd7b5f into main Nov 23, 2022
@trevor-scheer trevor-scheer deleted the trevor/update-keyvaluecache branch November 23, 2022 19:10
@github-actions github-actions bot mentioned this pull request Nov 23, 2022
trevor-scheer pushed a commit that referenced this pull request Nov 23, 2022
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @apollo/server-gateway-interface@1.0.7

### Patch Changes

- [#7187](#7187)
[`3fd7b5f26`](3fd7b5f)
Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Update
`@apollo/utils.keyvaluecache` dependency to the latest patch which
correctly specifies its version of `lru-cache`.

## @apollo/server-integration-testsuite@4.2.1

### Patch Changes

- [#7187](#7187)
[`3fd7b5f26`](3fd7b5f)
Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Update
`@apollo/utils.keyvaluecache` dependency to the latest patch which
correctly specifies its version of `lru-cache`.

- Updated dependencies
\[[`3fd7b5f26`](3fd7b5f)]:
    -   @apollo/server@4.2.1

## @apollo/server-plugin-response-cache@4.0.3

### Patch Changes

- [#7187](#7187)
[`3fd7b5f26`](3fd7b5f)
Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Update
`@apollo/utils.keyvaluecache` dependency to the latest patch which
correctly specifies its version of `lru-cache`.

## @apollo/server@4.2.1

### Patch Changes

- [#7187](#7187)
[`3fd7b5f26`](3fd7b5f)
Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Update
`@apollo/utils.keyvaluecache` dependency to the latest patch which
correctly specifies its version of `lru-cache`.

- Updated dependencies
\[[`3fd7b5f26`](3fd7b5f)]:
    -   @apollo/server-gateway-interface@1.0.7

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants