Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix v4.2.0 regression in variables: null (et al) #7203

Merged
merged 1 commit into from Nov 28, 2022
Merged

Fix v4.2.0 regression in variables: null (et al) #7203

merged 1 commit into from Nov 28, 2022

Commits on Nov 28, 2022

  1. Fix v4.2.0 regression in variables: null (et al) 

    In v4.2.0 (#7171) we changed POST handling to be stricter if
`operationName`, `variables`, or `extensions` were provided with a
surprising data type. This was intended to pass more of the optional
recommendations of the GraphQL Over HTTP spec as tested by the
graphql-http audit suite. However, we were overzealous and also banned
providing these parameters as an explicit `null`, which is documented by
the spec as legitimate. (And some clients, such as FIXME, actually send
`variables: null` in practice.)

We added explicit tests for this to the `graphql-http` test suite
(graphql/graphql-http#28) and this commit allows
these `null`s again.

Fixes #7200.
    @glasser
    glasser committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    8f36279 View commit details
    Browse the repository at this point in the history