Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove WHATWG URL, URLSearchParams imports, use globals #7228

Merged
merged 2 commits into from Dec 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/kind-drinks-carry.md
@@ -0,0 +1,6 @@
---
'@apollo/server-integration-testsuite': patch
'@apollo/server': patch
---

Improve compatibility with Cloudflare workers by avoiding the use of the Node `url` package. This change is intended to be a no-op.
1 change: 0 additions & 1 deletion packages/integration-testsuite/src/apolloServerTests.ts
@@ -1,6 +1,5 @@
import http from 'http';
import { createHash } from '@apollo/utils.createhash';
import { URL } from 'url';
import express from 'express';
import bodyParser from 'body-parser';
import loglevel from 'loglevel';
Expand Down
1 change: 0 additions & 1 deletion packages/server/src/runHttpQuery.ts
Expand Up @@ -18,7 +18,6 @@ import {
} from './ApolloServer.js';
import { FormattedExecutionResult, Kind } from 'graphql';
import { BadRequestError } from './internalErrorClasses.js';
import { URLSearchParams } from 'url';
import Negotiator from 'negotiator';
import { HeaderMap } from './utils/HeaderMap.js';

Expand Down