🔓 🐛 safelist cdn scripts in meta tag in landing page #7539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-server-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c81f738:
|
mayakoneval
force-pushed
the
maya/04-2023/meta-tags
branch
3 times, most recently
from
7264de5
to
fab9453
Compare
mayakoneval
changed the title
mayakoneval
force-pushed
the
maya/04-2023/meta-tags
branch
2 times, most recently
from
013a2e8
to
00deed7
Compare
…nce (sha256 of a uuid) to validate script tags in <meta
mayakoneval
force-pushed
the
maya/04-2023/meta-tags
branch
from
00deed7
to
c097098
Compare
mayakoneval
force-pushed
the
maya/04-2023/meta-tags
branch
from
ab314c7
to
9a0d2ab
Compare
Co-authored-by: Trevor Scheer <trevor.scheer@gmail.com>
mayakoneval
commented
May 2, 2023
mayakoneval
force-pushed
the
maya/04-2023/meta-tags
branch
from
13739eb
to
c81f738
Compare
Merged
trevor-scheer
pushed a commit
that referenced
this pull request
May 2, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @apollo/server-integration-testsuite@4.7.1 ### Patch Changes - Updated dependencies \[[`5d3c45be9`](5d3c45b)]: - @apollo/server@4.7.1 ## @apollo/server@4.7.1 ### Patch Changes - [#7539](#7539) [`5d3c45be9`](5d3c45b) + [#7540](#7540) [`42897532b`](42897532b5b7f691883988a149156a3294ed5404)Thanks [@mayakoneval](https://github.com/mayakoneval)! - 🐛 Bug Fix for Apollo Server Landing Pages on Safari. A Content Security Policy was added to our landing page html so that Safari can run the inline scripts we use to call the Embedded Sandbox & Explorer. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack context
Pierre found that in Safari the AS embedded Sandbo str8 up doesn't work ?! How long has this been going on without us knowing? Shocked.
Anyways, we needed to add a CSP for Safari to take these scripts seriously, and I did so via
<metatag. using thenonceoption.To test
Download the
apollo-server-typescriptcode sandbox example & install & run on Safari.