Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency graphql-http to v1.19.0 #7604

Merged
merged 2 commits into from Jun 15, 2023

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jun 10, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
graphql-http 1.18.0 -> 1.19.0 age adoption passing confidence

Release Notes

graphql/graphql-http

v1.19.0

Compare Source

Bug Fixes
  • use: process global is not available in all environments and NODE_ENV doesn't necessarily depict production vs. development (d08ead3)
Features

Configuration

📅 Schedule: Branch creation - "every weekend" in timezone America/Los_Angeles, Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the 🎄 dependencies Updates to dependencies, generally automatically managed by Renovate. label Jun 10, 2023
@netlify
Copy link

netlify bot commented Jun 10, 2023

Deploy Preview for apollo-server-docs ready!

Name Link
🔨 Latest commit 6e0c467
🔍 Latest deploy log https://app.netlify.com/sites/apollo-server-docs/deploys/6488bb99b8d13100084d071f
😎 Deploy Preview https://deploy-preview-7604--apollo-server-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 10, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6e0c467:

Sandbox Source
Apollo Server Typescript Configuration
Apollo Server Configuration

@renovate renovate bot force-pushed the renovate/graphql-http branch 2 times, most recently from 1e2a94a to f418021 Compare June 11, 2023 00:46
@renovate
Copy link
Contributor Author

renovate bot commented Jun 13, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@trevor-scheer trevor-scheer merged commit aeb511c into main Jun 15, 2023
20 checks passed
@trevor-scheer trevor-scheer deleted the renovate/graphql-http branch June 15, 2023 04:17
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
trevor-scheer pushed a commit that referenced this pull request Jun 15, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @apollo/server-integration-testsuite@4.7.4

### Patch Changes

- [#7604](#7604)
[`aeb511c7d`](aeb511c)
Thanks [@renovate](https://github.com/apps/renovate)! - Update
`graphql-http` dependency

-
[`0adaf80d1`](0adaf80)
Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Address
Content Security Policy issues

The previous implementation of CSP nonces within the landing pages did
not take full advantage of the security benefit of using them. Nonces
should only be used once per request, whereas Apollo Server was
generating one nonce and reusing it for the lifetime of the instance.
The reuse of nonces degrades the security benefit of using them but does
not pose a security risk on its own. The CSP provides a defense-in-depth
measure against a _potential_ XSS, so in the absence of a _known_ XSS
vulnerability there is likely no risk to the user.

The mentioned fix also coincidentally addresses an issue with using
crypto functions on startup within Cloudflare Workers. Crypto functions
are now called during requests only, which resolves the error that
Cloudflare Workers were facing. A recent change introduced a
`precomputedNonce` configuration option to mitigate this issue, but it
was an incorrect approach given the nature of CSP nonces. This
configuration option is now deprecated and should not be used for any
reason since it suffers from the previously mentioned issue of reusing
nonces.

Additionally, this change adds other applicable CSPs for the scripts,
styles, images, manifest, and iframes that the landing pages load.

A final consequence of this change is an extension of the
`renderLandingPage` plugin hook. This hook can now return an object with
an `html` property which returns a `Promise<string>` in addition to a
`string` (which was the only option before).

- Updated dependencies
\[[`0adaf80d1`](0adaf80)]:
    -   @apollo/server@4.7.4

## @apollo/server@4.7.4

### Patch Changes

-
[`0adaf80d1`](0adaf80)
Thanks [@trevor-scheer](https://github.com/trevor-scheer)! - Address
Content Security Policy issues

The previous implementation of CSP nonces within the landing pages did
not take full advantage of the security benefit of using them. Nonces
should only be used once per request, whereas Apollo Server was
generating one nonce and reusing it for the lifetime of the instance.
The reuse of nonces degrades the security benefit of using them but does
not pose a security risk on its own. The CSP provides a defense-in-depth
measure against a _potential_ XSS, so in the absence of a _known_ XSS
vulnerability there is likely no risk to the user.

The mentioned fix also coincidentally addresses an issue with using
crypto functions on startup within Cloudflare Workers. Crypto functions
are now called during requests only, which resolves the error that
Cloudflare Workers were facing. A recent change introduced a
`precomputedNonce` configuration option to mitigate this issue, but it
was an incorrect approach given the nature of CSP nonces. This
configuration option is now deprecated and should not be used for any
reason since it suffers from the previously mentioned issue of reusing
nonces.

Additionally, this change adds other applicable CSPs for the scripts,
styles, images, manifest, and iframes that the landing pages load.

A final consequence of this change is an extension of the
`renderLandingPage` plugin hook. This hook can now return an object with
an `html` property which returns a `Promise<string>` in addition to a
`string` (which was the only option before).

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🎄 dependencies Updates to dependencies, generally automatically managed by Renovate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant