Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency mocha to v5 #776

Merged
merged 1 commit into from Mar 13, 2018
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 19, 2018

This Pull Request updates dependency mocha from v4.1.0 to v5.0.4

Note: This PR was created on a configured schedule ("after 10pm every weekday,before 5am every weekday" in timezone America/Los_Angeles) and will not receive updates outside those times.

Release Notes

v5.0.0

Mocha starts off 2018 right by again dropping support for unmaintained rubbish.

Welcome @​vkarpov15 to the team!

💥 Breaking Changes

  • #​3148: Drop support for IE9 and IE10 ([@​Bamieh])
    Practically speaking, only code which consumes (through bundling or otherwise) the userland buffer module should be affected. However, Mocha will no longer test against these browsers, nor apply fixes for them.

🎉 Enhancements

🐛 Fixes

  • #​3187: Fix inaccurate test duration reporting (@​FND)
  • #​3202: Fix bad markup in HTML reporter (@​DanielRuf)

😎 Developer Experience

  • #​2352: Ditch GNU Make for nps to manage scripts (@​TedYav)

📖 Documentation

  • #​3137: Add missing --no-timeouts docs (@​dfberry)
  • #​3134: Improve done() callback docs (@​maraisr)
  • #​3135: Fix cross-references (@​vkarpov15)
  • #​3163: Fix tpyos (@​tbroadley)
  • #​3177: Tweak README.md organization ([@​xxczaki])
  • Misc updates ([@​boneskull])

🔩 Other

  • #​3118: Move TextMate Integration to its own repo ([@​Bamieh])
  • #​3185: Add Node.js v9 to build matrix; remove v7 ([@​xxczaki])
  • #​3172: Markdown linting ([@​boneskull])
  • Test & Netlify updates ([@​Munter], [@​boneskull])

v5.0.1

...your garden-variety patch release.

Special thanks to Wallaby.js for their continued support! ❤️

🐛 Fixes

  • #​1838: --delay now works with .only() (@​silviom)
  • #​3119: Plug memory leak present in v8 ([@​boneskull])

📖 Documentation

🔩 Other


v5.0.2

This release fixes a class of tests which report as false positives. Certain tests will now break, though they would have previously been reported as passing. Details below. Sorry for the inconvenience!

🐛 Fixes

  • #​3226: Do not swallow errors that are thrown asynchronously from passing tests ([@​boneskull]). Example:

    it('should actually fail, sorry!', function (done) {
      // passing assertion
      assert(true === true);
    
      // test complete & is marked as passing
      done();
    
      // ...but something evil lurks within
      setTimeout(() => {
        throw new Error('chaos!');
      }, 100);
    });

    Previously to this version, Mocha would have silently swallowed the chaos! exception, and you wouldn't know. Well, now you know. Mocha cannot recover from this gracefully, so it will exit with a nonzero code.

    Maintainers of external reporters: If a test of this class is encountered, the Runner instance will emit the end event twice; you may need to change your reporter to use runner.once('end') intead of runner.on('end').

  • #​3093: Fix stack trace reformatting problem (@​outsideris)

:nut_and_bolt Other


v5.0.3

This patch features a fix to address a potential "low severity" ReDoS vulnerability in the diff package (a dependency of Mocha).

🔒 Security Fixes

🔩 Other


v5.0.4

🐛 Fixes

  • #​3265: Fixes regression in "watch" functionality introduced in v5.0.2 (@​outsideris)

Commits

v5.0.0

  • c1da848 Update README.md
  • 5161639 Fix typos
  • ef981a2 Link to unexpected.js on http. Cert errors on https
  • 3e85f89 Ensure consistent calculation of duration
  • a554adb Update .travis.yml
  • 3f314b6 drop support for ie9 and ie10; closes https://github.com/mochajs/mocha/issues/3148
  • 95d2fe7 Update karma.conf.js
  • dc12bd5 test setup for ESM support
  • a723b8f lint Markdown; closes #​3172
  • b2697a7 add --no-timeouts to docs; closes #​3137 (#​3176)
  • cb09e8b document Error/undefined params to the 'done' callback; closes #​3134
  • e54370e replace phantomjs with puppeteer for browser tests; closes #​3128
  • 565726d Added Netlify config file
  • e8b5592 Align netlify config with admin panel
  • ac1dd70 attempt to get travis working again
  • 5c6e99b update ESM tests to run against headless chrome instead of saucelabs' chrome only
  • c7730a6 Drop TextMate integration inside mocha closes https://github.com/mochajs/mocha/issues/3118
  • 0a3e32b Rewrite Makefile using NPS Scripts. Closes #​2352
  • 7d8abe0 fix id and class definition
  • 50aec7a Add ability to pass in test files to be ran before positional files via --file (#​3190)
  • 401997f update package-lock.json
  • f8a1d2a docs(index): add missing doc link (#​3203); closes #​3135
  • dc58252 prep changelog for v5.0.0 [ci skip]
  • a7267b4 remove more references to make and Makefile
  • 9f61c04 finalize v5.0.0 CHANGELOG [ci skip]
  • cc4a818 Release v5.0.0

v5.0.1

  • c0ac1b9 fix travis "before script" script
  • 2fe2d01 Revert "fix travis "before script" script"
  • bca57f4 clarify docs on html, xunit and 3p reporters; closes #​1906
  • 2e7e4c0 rename "common-mistake" label to "faq"
  • 14fc030 Add all supported wallaby editors
  • f687d2b update docs for the glob
  • cd74322 Slight copy update on docs for test directory
  • b57f623 fix: When using --delay, .only() no longer works. Issue #​1838
  • 3509029 update .gitignore to only ignore root mocha.js [ci skip]
  • d975a6a fix memory leak when run in v8; closes #​3119
  • b7377b3 rename help-wanted to "help wanted" in stale.yml
  • 412cf27 [Update] license year
  • 44aae9f add working wallaby config
  • 70027b6 update changelog for v5.0.1 [ci skip]
  • 09ce746 Release v5.0.1
  • 73d55ac fix typos in changelog [ci skip]
  • c4ef568 fix PR url

v5.0.2

  • f71f347 rename wallaby.js -> .wallaby.js
  • ec8901a remove unused functionality in utils module
  • 3537061 Update to correctly licensed browser-stdout version
  • 2c720a3 do not eat exceptions thrown asynchronously from passed tests; closes #​3226
  • 5078fc5 persist paths in stack trace which have cwd as infix
  • 3792bef add opencollective header image to assets/
  • afcd08f add MAINTAINERS.md to .fossaignore [ci skip]
  • 0542c40 update README.md; closes #​3191 [ci skip]
  • 6a796cb prepare CHANGELOG for v5.0.2 [ci skip]
  • ff1bd9e update package-lock.json
  • f2ee53c Release v5.0.2

v5.0.3

  • bdcb3c3 exposes generateDiff function from base reporter
  • 660bccc adds unit tests covering Base.generateDiff
  • 8df5727 Tidies up code after review
  • aaaa5ab fix: ReDoS vuln in mocha@​5.0.2 › diff@​3.3.1 (#​3266)
  • 70d9262 update CHANGELOG.md for v5.0.3 [ci skip]
  • da6e5c9 Release v5.0.3

v5.0.4

  • eb09421 restore removed methods which still used
  • 868830a update CHANGELOG.md for v5.0.4 [ci skip]
  • 851ad29 Release v5.0.4

This PR has been generated by Renovate Bot.

@renovate renovate bot added 🎄 dependencies Updates to dependencies, generally automatically managed by Renovate. 🛠 tooling Relates to tooling within the Apollo Server repository, not Apollo Server itself. labels Jan 19, 2018
@renovate renovate bot force-pushed the renovate/mocha-5.x branch 7 times, most recently from 96b3c96 to c042744 Compare January 24, 2018 10:23
@renovate renovate bot force-pushed the renovate/mocha-5.x branch 7 times, most recently from 42c8cc5 to 73297fe Compare February 2, 2018 07:01
@renovate renovate bot force-pushed the renovate/mocha-5.x branch 14 times, most recently from 56ef99c to c3568d9 Compare February 12, 2018 11:01
@renovate renovate bot force-pushed the renovate/mocha-5.x branch 2 times, most recently from 91fde7c to eb8c18a Compare February 17, 2018 07:16
@renovate renovate bot force-pushed the renovate/mocha-5.x branch 9 times, most recently from dfd68ae to a49ea73 Compare March 1, 2018 11:01
@renovate renovate bot force-pushed the renovate/mocha-5.x branch 6 times, most recently from 87aacb3 to 50ccc20 Compare March 9, 2018 07:01
@renovate renovate bot force-pushed the renovate/mocha-5.x branch 6 times, most recently from c783018 to 2847ef8 Compare March 13, 2018 08:50
Copy link
Member

@abernix abernix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The breaking changes between Mocha 4.x and 5.x only affect browsers and we're only running server-based tests here in this server-only repository. Therefore, LGTM.

@abernix abernix merged commit 2ac6057 into master Mar 13, 2018
@abernix
Copy link
Member

abernix commented Mar 13, 2018

The failing tests are only prettier.

@renovate renovate bot deleted the renovate/mocha-5.x branch March 13, 2018 13:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🎄 dependencies Updates to dependencies, generally automatically managed by Renovate. 🛠 tooling Relates to tooling within the Apollo Server repository, not Apollo Server itself.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants